Depend on cli component of ignition-utils1 #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
chapulina
approved these changes
Mar 8, 2021
|
I just merged the updated sdformat11 homebrew bottle, which should fix CI here |
|
@osrf-jenkins run tests please |
|
update |
should be ready to merge as soon as the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Depend on the
clicomponent ofignition-utils1so that we can implement the backend of theigncommands as executables instead ofdlopencalls from ruby (similar to gazebosim/gz-transport#216). This just adds the dependency for now, so we can implement the functionality in a minor release if desired.Test it
It just needs to not break CI.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge