Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service to set camera's follow offset #855

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Jun 10, 2021

🎉 New feature

Summary

Added service /gui/follow/offset to set the user camera's follow offset.

Test it

ign gazebo diff_drive.sdf

ign service -s /gui/follow --reqtype ignition.msgs.StringMsg --reptype ignition.msgs.Boolean --timeout 2000 --req 'data: "vehicle_blue"'

# sets camera to face vechile_blue
ign service -s /gui/follow/offset --reqtype ignition.msgs.Vector3d --reptype ignition.msgs.Boolean --timeout 2000 --req "x: 5, y: 0, z: 3"

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@jennuine jennuine requested a review from chapulina as a code owner June 10, 2021 01:16
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jun 10, 2021
@jennuine jennuine self-assigned this Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #855 (85b559c) into ign-gazebo4 (5694336) will decrease coverage by 0.02%.
The diff coverage is 26.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #855      +/-   ##
===============================================
- Coverage        65.72%   65.69%   -0.03%     
===============================================
  Files              240      240              
  Lines            17783    17797      +14     
===============================================
+ Hits             11687    11691       +4     
- Misses            6096     6106      +10     
Impacted Files Coverage Δ
src/gui/plugins/scene3d/Scene3D.hh 66.66% <ø> (ø)
src/gui/plugins/scene3d/Scene3D.cc 9.64% <26.66%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5694336...85b559c. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, works for me

@iche033
Copy link
Contributor

iche033 commented Jun 10, 2021

while reviewing this PR, I found a small bug related to the camera follow offset checks and addressed it in #857

@nkoenig
Copy link
Contributor

nkoenig commented Jun 10, 2021

I'll try this out with some log files soon. Please wait for my approval before merging.

@jennuine jennuine merged commit 31676f5 into ign-gazebo4 Jun 10, 2021
@jennuine jennuine deleted the jennuine/follow_offset_service branch June 10, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants