Fix updating GUI plugin on load #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
ahcorde
added
the
needs upstream release
ahcorde
approved these changes
Jul 7, 2021
8 tasks
|
@osrf-jenkins retest this please |
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #904 +/- ##
===============================================
- Coverage 77.94% 77.92% -0.02%
===============================================
Files 215 215
Lines 12077 12080 +3
===============================================
Hits 9413 9413
- Misses 2664 2667 +3
Continue to review full report at Codecov.
|
|
@osrf-jenkins retest this please |
chapulina
removed
the
needs upstream release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Ignition GUI has been sending an empty string until now, see gazebosim/gz-gui#249. With that fix, the signal will send a unique string instead of the plugin name.
The current code is always getting the first plugin loaded, because they all have empty names. With this fix, the newly added plugin should be correctly got.
If the
ign-guiPR is released without this fix, users will be spammed with error messages that they can't get the plugin with nameplugin<number>.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸