3 to 4 #933
Merged
3 to 4 #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]> Co-authored-by: RafiAbdullah <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Marcos Wagner <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Franco Cipollone <[email protected]> Co-authored-by: Franco Cipollone <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: addy1997 <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: ahcorde <[email protected]> Removed changes to diff-drive command when backporting to ign-gazebo3 Signed-off-by: Louise Poubel <[email protected]>
Extend test to have two logical cameras observing the same box. Signed-off-by: Jaldert Rombouts <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
* Added world exporter Signed-off-by: Gonzalo de Pedro <[email protected]> * Fixed CMake Signed-off-by: Gonzalo de Pedro <[email protected]> * Changes based on review Signed-off-by: Gonzalo de Pedro <[email protected]> * Added example world Signed-off-by: Nate Koenig <[email protected]> * bump required ign-common version Signed-off-by: Louise Poubel <[email protected]> * PR updates Signed-off-by: Nate Koenig <[email protected]> * Update documentation to have simulation self terminate Signed-off-by: Nate Koenig <[email protected]> * Rename world_export to collada_world_exporter Signed-off-by: Nate Koenig <[email protected]> * Finish world exporter renaming Signed-off-by: Nate Koenig <[email protected]> * Revert change Signed-off-by: Nate Koenig <[email protected]> * Added a tutorial Signed-off-by: Nate Koenig <[email protected]> * Update transform Signed-off-by: Nate Koenig <[email protected]> * Added message Signed-off-by: Nate Koenig <[email protected]> * Added a test Signed-off-by: Nate Koenig <[email protected]> * Added more shapes Signed-off-by: Nate Koenig <[email protected]> * Cleanup in two locations Signed-off-by: Nate Koenig <[email protected]> * Fix build Signed-off-by: Nate Koenig <[email protected]> * Apply scale, and fix codecheck Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
…ts. (#629) Signed-off-by: Martin Pecka <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
adlarkin
added
the
needs upstream release
7 tasks
adlarkin
added a commit
that referenced
this pull request
Jul 27, 2021
Signed-off-by: Ashton Larkin <[email protected]>
adlarkin
force-pushed
the
adlarkin/3_to_4
branch
from
5efdfb0
to
02ee7c3
Compare
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #933 +/- ##
===============================================
+ Coverage 65.98% 66.26% +0.28%
===============================================
Files 239 240 +1
Lines 17686 17872 +186
===============================================
+ Hits 11670 11843 +173
- Misses 6016 6029 +13
Continue to review full report at Codecov.
|
|
It looks like macOS hasn't picked up on the new GUI release: https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-homebrew-amd64/6141/consoleFull#18361520546ea37b8d-a6d4-40ae-8431-d90c018842af However, the bottle has been built (I think): osrf/homebrew-simulation#1541 Is there a way to verify that macOS has picked up the new GUI release? |
Signed-off-by: Ashton Larkin <[email protected]>
adlarkin
force-pushed
the
adlarkin/3_to_4
branch
from
02ee7c3
to
d76a6c2
Compare
|
Now that the |
|
macOS is building now. The INTEGRATION_user_commands test failed again, but it has failed for the past 19 builds, so I don't think it's related to this PR. I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-gazebo3toign-gazebo4Branch comparison: ign-gazebo4...ign-gazebo3
I had to resolve a few merge conflicts. I believe that we will also need an
ign-gui4release in order to support #904, which is part of this forward-port.Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)