Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignition -> Gazebo #330

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Ignition -> Gazebo #330

merged 3 commits into from
Jul 19, 2022

Conversation

jennuine
Copy link
Contributor

🦟 Bug fix

Part of:

Summary

Updated links and naming in README.md

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jennuine
Ignition -> Gazebo
4d9515e 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine
fix typo
7c5b595 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine added the QA Quality assurance. label Jul 15, 2022
@jennuine jennuine requested a review from chapulina July 15, 2022 21:45
@jennuine jennuine requested a review from caguero as a code owner July 15, 2022 21:45
@jennuine jennuine self-assigned this Jul 15, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022 •
edited
Loading

Codecov Report

Merging #330 (c08face) into ign-transport8 (30da9d3) will increase coverage by 0.01%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           ign-transport8     #330      +/-   ##
==================================================
+ Coverage           83.81%   83.83%   +0.01%     
==================================================
  Files                  51       51              
  Lines                5035     5035              
==================================================
+ Hits                 4220     4221       +1     
+ Misses                815      814       -1
Impacted Files Coverage Δ
include/ignition/transport/Discovery.hh 87.94% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30da9d3...c08face. Read the comment docs.

chapulina
chapulina approved these changes Jul 15, 2022
View reviewed changes
README.md Outdated
Test coverage | [![codecov](https://codecov.io/gh/ignitionrobotics/ign-transport/branch/ign-transport8/graph/badge.svg)](https://codecov.io/gh/ignitionrobotics/ign-transport)
Ubuntu Bionic | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-ign-transport8-bionic-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-ign-transport8-bionic-amd64)
Test coverage | [![codecov](https://codecov.io/gh/gazebosim/gz-transport/branch/ign-transport8/graph/badge.svg)](https://codecov.io/gh/gazebosim/gz-transport/branch/ign-transport8)
Ubuntu Focal | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-ign-transport8-focal-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-ign-transport8-focal-amd64)
Homebrew | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-ign-transport8-homebrew-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-ign-transport8-homebrew-amd64)
Windows | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-ign-transport8-windows7-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-ign-transport8-windows7-amd64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use this opportunity to update the Windows badge, this is the new job:

https://build.osrfoundation.org/job/ign_transport-ign-8-win

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c08face

@jennuine
update win badge
c08face 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine added the needs upstream release Blocked by a release of an upstream library label Jul 18, 2022
@jennuine
Copy link
Contributor Author

Failing Homebrew CI requires this gz-msgs fix

@jennuine jennuine mentioned this pull request Jul 18, 2022
Merged
5 tasks
@jennuine jennuine removed the needs upstream release Blocked by a release of an upstream library label Jul 19, 2022
@jennuine jennuine merged commit 0be3a49 into ign-transport8 Jul 19, 2022
@jennuine jennuine deleted the jennuine/readme_updates branch July 19, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees

@jennuine jennuine

Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 QA Quality assurance.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennuine @chapulina