Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Plugin - When item is selected from list text is not populated on the Search Bar #9311

Closed
1 task done
ale-cristofori opened this issue Jul 28, 2023 · 1 comment · Fixed by #9321
Closed
1 task done

Search Plugin - When item is selected from list text is not populated on the Search Bar #9311

ale-cristofori opened this issue Jul 28, 2023 · 1 comment · Fixed by #9321
Assignees
@ale-cristofori @ElenaGallo
Labels
Accepted C027-COMUNE_FI-2023-SUPPORT enhancement
Milestone
2023.02.00

Comments

@ale-cristofori
Copy link
Contributor

Description

When performing a search from the map page search bar, results appear and when selecting the desired one the selected text should populate the search bar, this does not happen currently. Looks like a regression.

How to reproduce

  • Open a map with the search plugin (top right corner)
  • Type some text to search
  • select the desired result from the list
  • the selection triggers the zoom to the selected area and the highlighting of the selected searched area but the search text box is not populated with the selected item text result.

Expected Result
The search text box should be populated with the selected item text.
https:/geosolutions-it/MapStore2/assets/14953970/9e082e0c-ab2e-421e-8d5b-e4dd6ddc4f94

Current Result
The search text box is not populated with the selected item text but with the text typed by the user.

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@ale-cristofori ale-cristofori self-assigned this Jul 28, 2023
@ale-cristofori ale-cristofori added this to the 2023.02.00 milestone Jul 28, 2023
ale-cristofori pushed a commit to ale-cristofori/MapStore2 that referenced this issue Aug 2, 2023
Issue geosolutions-it#9311 - Search Plugin - Populates the Search Bar…
176fb3f 
… on item selection

This commit introduces code to populate the search bar plugin upon user
clicks/selects an item returned from the search list. The design has taken
into account both 'NOMINATIM' and custom WFS services created by the user.
@ale-cristofori ale-cristofori added New Feature used for new functionalities and removed bug labels Aug 2, 2023
@ale-cristofori ale-cristofori mentioned this issue Aug 2, 2023
Merged
12 tasks
@ale-cristofori ale-cristofori linked a pull request Aug 2, 2023 that will close this issue
Issue #9311 - populate search bar on select #9321
Merged
12 tasks
@ale-cristofori
Copy link
Contributor Author

@ElenaGallo, this is ready to be tested on DEV

tdipisa pushed a commit that referenced this issue Aug 10, 2023
@ale-cristofori
Issue #9311 - populate search bar on select (#9321)
6a95a9f 
* Issue #9311 - Search Plugin - Populates the Search Bar on item selection

This commit introduces code to populate the search bar plugin upon user
clicks/selects an item returned from the search list. The design has taken
into account both 'NOMINATIM' and custom WFS services created by the user.

* included missing JSDOC for selectSearchItem action

---------

Co-authored-by: Alessandro Cristofori <[email protected]>
@ElenaGallo ElenaGallo self-assigned this Aug 21, 2023
@tdipisa tdipisa added enhancement and removed New Feature used for new functionalities labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ale-cristofori ale-cristofori

@ElenaGallo ElenaGallo

Labels
Accepted C027-COMUNE_FI-2023-SUPPORT enhancement
Projects
None yet
Milestone
2023.02.00
Development

Successfully merging a pull request may close this issue.

Issue #9311 - populate search bar on select ale-cristofori/MapStore2
3 participants
@tdipisa @ale-cristofori @ElenaGallo