Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #9311 - populate search bar on select #9321

Conversation

ale-cristofori
Copy link
Contributor

Description

When performing a search from the map page search bar, results appear and when selecting the desired one the selected text should populate the search bar.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#9311

What is the current behavior?
The search text box is not populated with the selected item text but with the text typed by the user.
#9311

What is the new behavior?
The search text box should be populated with the selected item text.
https:/geosolutions-it/MapStore2/assets/14953970/9e082e0c-ab2e-421e-8d5b-e4dd6ddc4f94

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Alessandro Cristofori added 2 commits August 2, 2023 16:29
… on item selection

This commit introduces code to populate the search bar plugin upon user
clicks/selects an item returned from the search list. The design has taken
into account both 'NOMINATIM' and custom WFS services created by the user.
…into 9311-populate-search-bar-on-select
@ale-cristofori ale-cristofori added this to the 2023.02.00 milestone Aug 2, 2023
@ale-cristofori ale-cristofori self-assigned this Aug 2, 2023
@tdipisa tdipisa requested a review from MV88 August 2, 2023 14:48
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one little thing

web/client/actions/search.js Show resolved Hide resolved
Copy link
Contributor Author

@ale-cristofori ale-cristofori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-reviewed and modified as requested

…into 9311-populate-search-bar-on-select
@tdipisa
Copy link
Member

tdipisa commented Aug 10, 2023

@ElenaGallo please test this in DEV.

@tdipisa tdipisa merged commit 6a95a9f into geosolutions-it:master Aug 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C027-COMUNE_FI-2023-SUPPORT New Feature used for new functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Plugin - When item is selected from list text is not populated on the Search Bar
3 participants