Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving GeoFence rule filtering capabilities #9510

Closed
1 of 6 tasks
mahmoudadel54 opened this issue Sep 28, 2023 · 0 comments · Fixed by #9557, #9715 or #9716
Closed
1 of 6 tasks

Improving GeoFence rule filtering capabilities #9510

mahmoudadel54 opened this issue Sep 28, 2023 · 0 comments · Fixed by #9557, #9715 or #9716

Comments

@mahmoudadel54
Copy link
Contributor

mahmoudadel54 commented Sep 28, 2023

Description

The current filter provided by the GeoFence access rules manager works on top of the GeoFence REST APIs. As default behavior, the result of each column filter is the set of rules that are applied somehow to the filter itself (the value specified in the filter field). This means that filtering for user 'A' will list all rules applied to that user (that meant not only the rules with the value 'A' in the user field).
image

Thanks to the current GeoFence APIs it is possible to specify an additional attribute in the REST request to list rules strictly matching with the value (e.g. userAny, the full list for each supported rule field is available here)

For example this REST request will return rules having SITGEO as workspace value:
https://localhost:8080/geofence/rest/rules?page=1&entries=20&workspace=SITGEO&workspaceany=false

As part of this issue it is requested to provide the needed UI to let the user choose which kind of filtermode should be applied for each column filter. This means that a checkbox should be added beside each column filter to allow this (e.g. strict=true/false, default is false that means for example workspaceany=true)

rulemanager doc here

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

@mahmoudadel54 mahmoudadel54 self-assigned this Sep 28, 2023
@tdipisa tdipisa added this to the 2023.02.01 milestone Sep 28, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 4, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 4, 2023
@mahmoudadel54 mahmoudadel54 linked a pull request Oct 5, 2023 that will close this issue
11 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 27, 2023
* resolve all the comments
* Move checkbox to the right of the combobox with some space between combobox and checkbox
* Add tooltip on the checkbox + translation
* Checkbox is enables by default
*  Change placeholder value to “ANY” + translation
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 30, 2023
* resolve all the comments
* Move checkbox to the right of the combobox with some space between combobox and checkbox
* Add tooltip on the checkbox + translation
* Checkbox is enables by default
*  Change placeholder value to “ANY” + translation
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 30, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 31, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 31, 2023
@MV88 MV88 closed this as completed in #9557 Nov 3, 2023
MV88 pushed a commit that referenced this issue Nov 3, 2023
* #9510: enhance rule manager grid by adding checkbox filter mode
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 3, 2023
@ElenaGallo ElenaGallo self-assigned this Nov 14, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 17, 2023
** description:
- fix css issue of white space below dropdown lists if user selects one item from them in rules manager page
- fix issue in filtering roles dropdown
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 17, 2023
** description:
- fix css issue of white space below dropdown lists if user selects one item from them in rules manager page
- fix issue in filtering roles dropdown
MV88 pushed a commit that referenced this issue Nov 17, 2023
** description:
- fix css issue of white space below dropdown lists if user selects one item from them in rules manager page
- fix issue in filtering roles dropdown
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 20, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 20, 2023
** description:
- fix css issue of white space below dropdown lists if user selects one item from them in rules manager page
- fix issue in filtering roles dropdown
MV88 added a commit that referenced this issue Nov 21, 2023
[Backport 2023.02.xx]: #9510: Improving GeoFence rule filtering capabilities (#9715,#9715)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment