Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9510: Improving GeoFence rule filtering capabilities [fix rule manager roles filter] #9715

Merged

Conversation

mahmoudadel54
Copy link
Contributor

Description

  • fix issue in filtering roles dropdown in rules manager page
  • fix CSS issue of white space below dropdown lists if user selects one item from them in rules manager page

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#9510

What is the current behavior?
#9510

What is the new behavior?
Role filters is working as required now + the white space below the dropdown lists is fixed.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

** description:
- fix css issue of white space below dropdown lists if user selects one item from them in rules manager page
- fix issue in filtering roles dropdown
@mahmoudadel54 mahmoudadel54 added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C040-COMUNE_GE-2023-CUSTOM-SUPPORT labels Nov 17, 2023
@mahmoudadel54 mahmoudadel54 added this to the 2023.02.01 milestone Nov 17, 2023
@mahmoudadel54 mahmoudadel54 self-assigned this Nov 17, 2023
@mahmoudadel54 mahmoudadel54 linked an issue Nov 17, 2023 that may be closed by this pull request
6 tasks
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MV88 MV88 merged commit 1e51fd9 into geosolutions-it:master Nov 17, 2023
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Nov 17, 2023

@ElenaGallo please test it in DEV

@ElenaGallo
Copy link
Contributor

Test passed, @mahmoudadel54 please backport this pr to 2023.02.xx branch. Thanks

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Nov 20, 2023
** description:
- fix css issue of white space below dropdown lists if user selects one item from them in rules manager page
- fix issue in filtering roles dropdown
MV88 added a commit that referenced this pull request Nov 21, 2023
[Backport 2023.02.xx]: #9510: Improving GeoFence rule filtering capabilities (#9715,#9715)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 21, 2023
@mahmoudadel54
Copy link
Contributor Author

Test passed, @mahmoudadel54 please backport this pr to 2023.02.xx branch. Thanks

Backport is done ---> #9716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving GeoFence rule filtering capabilities
4 participants