Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details panel for MS dashboards #9683

Closed
3 tasks
mahmoudadel54 opened this issue Nov 7, 2023 · 5 comments · Fixed by #9689, #9730 or #9740
Closed
3 tasks

Details panel for MS dashboards #9683

mahmoudadel54 opened this issue Nov 7, 2023 · 5 comments · Fixed by #9689, #9730 or #9740
Assignees
Milestone

Comments

@mahmoudadel54
Copy link
Contributor

mahmoudadel54 commented Nov 7, 2023

Description

It is requested the implementation of a Details panel for Dashboards

Acceptance criteria

  • The tool should be defined in the same way of the corresponding one for maps. We could also consider to move the details definition outside the Save modal
  • The tool should have the same options of the existing one (eg. show as modal, show at startup etc.)
  • It should be possible to open it from the left side toolbar

Other useful information

@mahmoudadel54 mahmoudadel54 self-assigned this Nov 7, 2023
@mahmoudadel54 mahmoudadel54 added this to the 2024.01.00 milestone Nov 7, 2023
@mahmoudadel54
Copy link
Contributor Author

This is a simple demo showing the layout change --> I have tried, it helps yes but doesn't give the required style in sidebar

"name": "SidebarMenu",
"cfg" : {
  "containerPosition": "columns"
  }
}

So I have to put a flag in sideBarMenu plugin if it is dashboard ---> edit style to be like that [just 2 lines in css]

@tdipisa @MV88
Is it suitable ? for layout

details.panel.in.ms.mp4

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 10, 2023
-  The tool have the same options (eg. show as modal, show at startup etc.)
- The tool is defined in the same way of the corresponding one for maps.
- Edit the layout to put add widget & show/hide connection buttons to the sidebar menu
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 13, 2023
Update DashboardEditor.jsx
@tdipisa tdipisa linked a pull request Nov 14, 2023 that will close this issue
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 15, 2023
* description:
- remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard.
- add missing test for detailsLoaded action
- create new selectors, details uri selector and details settings se;ector that are used in many places in code
- move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder
- Put global spinner in details plugin and remove it from sidebar plugin
-  edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard
- Add custom style in details.less as the lib of react-dock doesn't allow to override left css property
- remove unused added style from panels.less
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 15, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 20, 2023
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 20, 2023
Description:
- edit navbar.less files to fix going language selector behind body panel
- remove unused z-index in dashboard.less
MV88 pushed a commit that referenced this issue Nov 21, 2023
* #9683: add Details Panel for MS dashboard
-  The tool have the same options (eg. show as modal, show at startup etc.)
- The tool is defined in the same way of the corresponding one for maps.
- Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

* #9683: resolve the FE test

Update DashboardEditor.jsx

* #9683: resolve review comments
* description:
- remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard.
- add missing test for detailsLoaded action
- create new selectors, details uri selector and details settings se;ector that are used in many places in code
- move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder
- Put global spinner in details plugin and remove it from sidebar plugin
-  edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard
- Add custom style in details.less as the lib of react-dock doesn't allow to override left css property
- remove unused added style from panels.less

* #9683: remove unused comments in dashboard-test file

* #9683: edit in details epics and selectors to fix FE test

* #9683: Resolve review comments
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style

* #9683: resolve review comments
Description:
- edit navbar.less files to fix going language selector behind body panel
- remove unused z-index in dashboard.less
@ElenaGallo ElenaGallo self-assigned this Nov 21, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 22, 2023
- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 22, 2023
- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard
MV88 pushed a commit that referenced this issue Nov 22, 2023
- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard
@ElenaGallo
Copy link
Contributor

ElenaGallo commented Nov 23, 2023

@mahmoudadel54 sorry for the double comment, I also noticed that:

  • the connections button, when disabled, is blue instead of white. Open this dashboard

Image

  • the details tooltips report About this map instead About this dashboard

Image

@tdipisa
Copy link
Member

tdipisa commented Nov 23, 2023

@ElenaGallo @mahmoudadel54

the details tooltips report About this map instead About this dashboard

not only the tooltip, also the panel title is reporting the same while it should be resource related.

image

@mahmoudadel54
Copy link
Contributor Author

mahmoudadel54 commented Nov 23, 2023

@tdipisa @ElenaGallo
Can I make it "About this content" ? to make it generic for the future if geostory needs to use this as well ?

image

@MV88
Copy link
Contributor

MV88 commented Nov 23, 2023

@tdipisa @ElenaGallo Can I make it "About this content" ? to make it generic for the future if geostory needs to use this as well ?

image

yes go ahead

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 23, 2023
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip
MV88 added a commit that referenced this issue Nov 23, 2023
…ooltip and title] (#9740)

* #9683: resolve test comment
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: Matteo V <[email protected]>
MV88 added a commit to MV88/MapStore2 that referenced this issue Nov 24, 2023
…s-it#9689)

* geosolutions-it#9683: add Details Panel for MS dashboard
-  The tool have the same options (eg. show as modal, show at startup etc.)
- The tool is defined in the same way of the corresponding one for maps.
- Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

* geosolutions-it#9683: resolve the FE test

Update DashboardEditor.jsx

* geosolutions-it#9683: resolve review comments
* description:
- remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard.
- add missing test for detailsLoaded action
- create new selectors, details uri selector and details settings se;ector that are used in many places in code
- move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder
- Put global spinner in details plugin and remove it from sidebar plugin
-  edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard
- Add custom style in details.less as the lib of react-dock doesn't allow to override left css property
- remove unused added style from panels.less

* geosolutions-it#9683: remove unused comments in dashboard-test file

* geosolutions-it#9683: edit in details epics and selectors to fix FE test

* geosolutions-it#9683: Resolve review comments
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style

* geosolutions-it#9683: resolve review comments
Description:
- edit navbar.less files to fix going language selector behind body panel
- remove unused z-index in dashboard.less
# Conflicts:
#	web/client/epics/__tests__/config-test.js
#	web/client/epics/config.js
MV88 pushed a commit to MV88/MapStore2 that referenced this issue Nov 24, 2023
- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard
MV88 added a commit to MV88/MapStore2 that referenced this issue Nov 24, 2023
… detail panel tooltip and title] (geosolutions-it#9740)

* geosolutions-it#9683: resolve test comment
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: Matteo V <[email protected]>
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 24, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 27, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 27, 2023
- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 27, 2023
… detail panel tooltip and title] (geosolutions-it#9740)

* geosolutions-it#9683: resolve test comment
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: Matteo V <[email protected]>
tdipisa pushed a commit that referenced this issue Nov 27, 2023
* Fix #9624 Point cloud shading options (#9666)

* Fix #9666 Include pointCloudShading option to saved layer config (#9670)

* #9606 Error with circle annotations + radius selection (#9607) (#9727)

Co-authored-by: Diego Vargas <[email protected]>

* Fix #9295 added better handling of format in csw service (#9712) (#9732)

* #9702: Fix - Background selector in contexts won't retain thumbnail in view mode (#9720) (#9744)

* #9567: handle functionality of zoom to record in table widgets (#9608)

* #9567: handle functionality of zoom to record in table widgets

* Fix: Correct failing test cases for zoom records issue in table widgets (#9567)
This commit addresses the failing test cases related to the issue of zoom records in table widgets.
* #9567: implement the new approach in zoom to records in table widgets + writing unit tests
* #9567: handle adding flag into config file to show/hide zoom icon for tblWidget
* #9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer
* #9567: resolve comments' review:
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead

* #9683: add Details Panel for MS dashboard (#9689)

* #9683: add Details Panel for MS dashboard
-  The tool have the same options (eg. show as modal, show at startup etc.)
- The tool is defined in the same way of the corresponding one for maps.
- Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

* #9683: resolve the FE test

Update DashboardEditor.jsx

* #9683: resolve review comments
* description:
- remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard.
- add missing test for detailsLoaded action
- create new selectors, details uri selector and details settings se;ector that are used in many places in code
- move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder
- Put global spinner in details plugin and remove it from sidebar plugin
-  edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard
- Add custom style in details.less as the lib of react-dock doesn't allow to override left css property
- remove unused added style from panels.less

* #9683: remove unused comments in dashboard-test file

* #9683: edit in details epics and selectors to fix FE test

* #9683: Resolve review comments
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style

* #9683: resolve review comments
Description:
- edit navbar.less files to fix going language selector behind body panel
- remove unused z-index in dashboard.less
# Conflicts:
#	web/client/epics/__tests__/config-test.js
#	web/client/epics/config.js

* #9683: resolve test comment (#9730)

- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard

* #9683: add Details Panel for MS dashboard [Editing the detail panel tooltip and title]  (#9740)

* #9683: resolve test comment
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: Matteo V <[email protected]>

* #9728 fix misalignement issue (#9731) (#9742)

* Fix #9729 fixed formats in catalog used in dashboard (#9733) (#9747)

---------

Co-authored-by: stefano bovio <[email protected]>
Co-authored-by: Diego Vargas <[email protected]>
Co-authored-by: Suren <[email protected]>
Co-authored-by: mahmoud adel <[email protected]>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment