Update mapstore-migration-guide.md #9926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV88
requested changes
Jan 30, 2024
MV88
reviewed
Mar 4, 2024
Comment on lines
40
to
44
| "name": "Menu", | ||
| "cfg": { | ||
| "containerPosition": "columns" | ||
| } | ||
| }, |
There was a problem hiding this comment.
I think it was SidebarMenu :)
MV88
requested changes
Mar 4, 2024
offtherailz
commented
Mar 4, 2024
MV88
approved these changes
Mar 6, 2024
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Apr 10, 2024
* Update mapstore-migration-guide.md * Update mapstore-migration-guide.md * Update docs/developer-guide/mapstore-migration-guide.md --------- Co-authored-by: Matteo V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this migration guidelines the replacement of
BurgerMenuwithSidebarMenuis not reported. Here the correct instructions.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
I think the issues were #9780 and/or #9683 , not sure. Anyway following the migration guidelines, we do not update the application correctly.
What is the new behavior?
The updated dashboard now is aligned with dev.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information