Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8871 Improve getLegendGraphic compatibility for print #10041

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

offtherailz
Copy link
Member

Description

This PR fixes what reported in #8871 , making the request exclude the LANGUAGE parameter if not necessary, making the getLegendGraphic compatible with servers that added some localization for GeoServer's UI that do not tollerate the language parameter.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#8871

What is the new behavior?
Fix #8871

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz added this to the 2024.01.00 milestone Mar 7, 2024
@offtherailz offtherailz self-assigned this Mar 7, 2024
@offtherailz offtherailz added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 7, 2024
@offtherailz offtherailz requested a review from MV88 March 7, 2024 11:15
@tdipisa tdipisa requested review from allyoucanmap and removed request for MV88 March 7, 2024 11:31
@allyoucanmap allyoucanmap merged commit 278a75a into geosolutions-it:master Mar 7, 2024
6 checks passed
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test on dev and let us know if we can backport on 2024.01.xx, thanks

@ElenaGallo
Copy link
Contributor

Test passed, @offtherailz please backport on 2024.01.xx, thanks

@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 11, 2024
@tdipisa tdipisa modified the milestones: 2024.01.00, 2024.01.02 Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty Language parameter in printing legend seems to be refused by some servers.
4 participants