Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2024.01.xx] #8871 Improve getLegendGraphic compatibility for print (#10041) #10443

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

tdipisa
Copy link
Member

@tdipisa tdipisa commented Jun 25, 2024

Description

[Backport 2024.01.xx] #8871 Improve getLegendGraphic compatibility for print (#10041)
fix #8871

Due to a mistake the previous one was targeting master branch instead of the stable one:
#10043

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#8871

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz
Copy link
Member

offtherailz commented Jun 26, 2024

The test was failing because this change was missing

278a75a#diff-f9adade1c5fe5f90a8653a2480feec27e73d07bd4b9cc12d6371fd6e8c240bacL579

@offtherailz offtherailz enabled auto-merge (squash) June 26, 2024 10:37
@offtherailz
Copy link
Member

offtherailz commented Jun 26, 2024

@ElenaGallo, could you please test this on QA as soon as merged and deployed ? Thank you

@offtherailz offtherailz merged commit e072d7f into geosolutions-it:2024.01.xx Jun 26, 2024
5 checks passed
@ElenaGallo
Copy link
Contributor

Test passed on QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty Language parameter in printing legend seems to be refused by some servers.
4 participants