Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9268: Fix domain values on empty areas #9570

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

offtherailz
Copy link
Member

Description

The issue #9268 was caused by rangeData (data on the current timeline viewport downloaded) to not have complete priority over domain data, that happened only when the domain values are less than 20.

In fact in this case, the back-end lists all of them, not only the generic interval (startDate--endDate) and the code didn't take into account this use case.

During the investigation we have also found another issue concerning the filter on viewport when the timeline was closed

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2023.10.06-15_15_48.webm

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

#9268

What is the new behavior?
Fix #9268

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz added this to the 2024.01.00 milestone Oct 6, 2023
@offtherailz offtherailz self-assigned this Oct 6, 2023
@offtherailz offtherailz marked this pull request as draft October 6, 2023 13:21
@offtherailz offtherailz marked this pull request as ready for review November 22, 2023 08:31
@ale-cristofori
Copy link
Contributor

ale-cristofori commented Nov 27, 2023

@offtherailz, I tested the PR and it is working as expected. I am going to assign this to a developer for a review. There are still a couple of questions open that do not pertain to this PR

@ale-cristofori ale-cristofori requested review from dsuren1 and removed request for ale-cristofori November 27, 2023 17:02
@dsuren1 dsuren1 merged commit 13cd074 into geosolutions-it:master Dec 1, 2023
6 checks passed
@tdipisa
Copy link
Member

tdipisa commented Dec 1, 2023

@ElenaGallo please test in DEV once deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeLine component for time ranges - Filter does not work correctly
4 participants