Skip to content

Commit

Permalink
feat: Add docutils_compat, fix warning (#15)
Browse files Browse the repository at this point in the history
  • Loading branch information
tony authored Oct 1, 2022
2 parents 74f6f15 + 215fd78 commit 895c598
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 2 deletions.
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ default_section = THIRDPARTY
include_trailing_comma = true
multi_line_output = 3
known_pytest = pytest,py
known_first_party = gp_libs,doctest_docutils,linkify_issues,pytest_doctest_docutils
known_first_party = gp_libs,doctest_compat,doctest_docutils,linkify_issues,pytest_doctest_docutils
sections = FUTURE,STDLIB,PYTEST,THIRDPARTY,FIRSTPARTY,LOCALFOLDER
line_length = 88

Expand Down
19 changes: 19 additions & 0 deletions src/docutils_compat.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
"""Helpers for cross compatibility across dependency versions."""
import typing as t

if t.TYPE_CHECKING:
from docutils.nodes import Node

_N = t.TypeVar("_N", bound=Node)


def findall(node: t.Type["_N"]) -> t.Callable[..., t.Iterable["_N"]]:
"""Iterate through nodes.
nodes.findall() replaces traverse in docutils v0.18.
findall is an iterator.
Based on myst_parser v0.18.1's:
https:/executablebooks/MyST-Parser/blob/v0.18.1/myst_parser/_compat.py
"""
return getattr(node, "findall", node.traverse)
4 changes: 3 additions & 1 deletion src/linkify_issues.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
from sphinx.application import Sphinx
from sphinx.transforms import SphinxTransform

from docutils_compat import findall

if sys.version_info >= (3, 8):
from typing import TypedDict
else:
Expand Down Expand Up @@ -40,7 +42,7 @@ def condition(node: nodes.Node) -> bool:
)
return cond

for node in self.document.traverse(condition):
for node in findall(self.document)(condition):
text = node.astext()
retnodes = []
pos = 0
Expand Down

0 comments on commit 895c598

Please sign in to comment.