Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add docutils_compat, fix warning #15

Merged
merged 2 commits into from
Oct 1, 2022
Merged

feat: Add docutils_compat, fix warning #15

merged 2 commits into from
Oct 1, 2022

Conversation

tony
Copy link
Member

@tony tony commented Oct 1, 2022

After upgrading libvcs's docutils to v0.19, pytest has a warning:

.venv/lib/python3.10/site-packages/doctest_docutils.py:328: 19 warnings
  ~/libtmux/.venv/lib/python3.10/site-packages/doctest_docutils.py:328: PendingDeprecationWarning: nodes.Node.traverse() is obsoleted by Node.findall().
    for idx, node in enumerate(doc.traverse(condition)):

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2022

Codecov Report

Merging #15 (215fd78) into master (74f6f15) will increase coverage by 0.12%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   60.48%   60.60%   +0.12%     
==========================================
  Files           9       10       +1     
  Lines         625      632       +7     
==========================================
+ Hits          378      383       +5     
- Misses        247      249       +2     
Impacted Files Coverage Δ
src/docutils_compat.py 66.66% <66.66%> (ø)
src/linkify_issues.py 95.74% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tony referenced this pull request in executablebooks/MyST-Parser Oct 1, 2022
@tony tony merged commit 895c598 into master Oct 1, 2022
@tony tony deleted the docutils-compat branch October 1, 2022 19:24
tony added a commit that referenced this pull request Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants