Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When grpc generates a controller, replace - with _ #2629

Closed
liangguifeng opened this issue May 7, 2023 · 2 comments
Closed

When grpc generates a controller, replace - with _ #2629

liangguifeng opened this issue May 7, 2023 · 2 comments

Comments

@liangguifeng
Copy link
Contributor

1. What version of Go and system type/arch are you using?

2. What version of GoFrame are you using?

3. Can this issue be re-produced with the latest release?

4. What did you do?

中文:gf的项目名称带了-关键字,在 gprc 生成 controller 的时候,controller 的包名也是带 - 的,这个是不符合 go 的包名规范的,而对于项目来说,很多人会以 - 来命名项目,应该将项目名称中带 - 的,替换为 _ 下划线,这样就符合规范了
英文:The project name of gf has the - keyword. When gprc generates controller, the package name of controller also contains -. This does not conform to the package name specification of go. For the project For example, many people will name projects with -, you should replace - in the project name with _ underscore, so that it conforms to the specification

5. What did you expect to see?

6. What did you see instead?

@liangguifeng
Copy link
Contributor Author

fix pull request: #2630

@liangguifeng
Copy link
Contributor Author

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant