Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When repairing protobuf to generate controllers, if the project … #2630

Merged
merged 1 commit into from
May 11, 2023

Conversation

liangguifeng
Copy link
Contributor

中文:gf的项目名称带了-关键字,在 gprc 生成 controller 的时候,controller 的包名也是带 - 的,这个是不符合 go 的包名规范的,而对于项目来说,很多人会以 - 来命名项目,应该将项目名称中带 - 的,替换为 _ 下划线,这样就符合规范了
英文:The project name of gf has the - keyword. When gprc generates controller, the package name of controller also contains -. This does not conform to the package name specification of go. For the project For example, many people will name projects with -, you should replace - in the project name with _ underscore, so that it conforms to the specification

…name contains a "-", the package name should also be named with a "-"
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (1408385) 78.83% compared to head (dadc1eb) 78.83%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2630      +/-   ##
==========================================
- Coverage   78.83%   78.83%   -0.01%     
==========================================
  Files         631      631              
  Lines       51715    51715              
==========================================
- Hits        40770    40768       -2     
- Misses       8924     8926       +2     
  Partials     2021     2021              
Flag Coverage Δ
go-1.15-386 78.85% <ø> (+0.09%) ⬆️
go-1.15-amd64 78.84% <ø> (-0.02%) ⬇️
go-1.16-386 78.84% <ø> (-0.02%) ⬇️
go-1.16-amd64 78.84% <ø> (-0.03%) ⬇️
go-1.17-386 78.82% <ø> (-0.03%) ⬇️
go-1.17-amd64 78.86% <ø> (+0.02%) ⬆️
go-1.18-386 78.78% <ø> (+<0.01%) ⬆️
go-1.18-amd64 78.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 43d439a into gogf:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants