Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isue #2976, to be compatible with bad response type definition for strict route function #2977

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Sep 21, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.26% 🎉

Comparison is base (5219c5c) 79.08% compared to head (7619287) 79.34%.
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2977      +/-   ##
==========================================
+ Coverage   79.08%   79.34%   +0.26%     
==========================================
  Files         643      643              
  Lines       52744    52815      +71     
==========================================
+ Hits        41710    41906     +196     
+ Misses       8952     8824     -128     
- Partials     2082     2085       +3     
Flag Coverage Δ
go-1.18-386 79.42% <100.00%> (?)
go-1.18-amd64 79.42% <100.00%> (+0.33%) ⬆️
go-1.19-386 79.31% <100.00%> (+0.32%) ⬆️
go-1.19-amd64 79.32% <100.00%> (+0.27%) ⬆️
go-1.20-386 79.29% <100.00%> (?)
go-1.20-amd64 79.42% <100.00%> (+0.26%) ⬆️
go-1.21-386 79.38% <100.00%> (+0.29%) ⬆️
go-1.21-amd64 79.43% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
net/ghttp/ghttp_server_service_handler.go 64.23% <100.00%> (+0.97%) ⬆️

... and 48 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WankkoRee WankkoRee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还原了 #2850 ,所以我认为没问题。

@gqcn gqcn merged commit df92c48 into master Sep 25, 2023
24 checks passed
@gqcn gqcn deleted the fix/2976 branch September 25, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants