Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image #2412

Merged
merged 8 commits into from
Aug 20, 2021
Merged

Update image #2412

merged 8 commits into from
Aug 20, 2021

Conversation

jonathanmetzman
Copy link
Collaborator

No description provided.

@google-cla google-cla bot added the cla: yes CLA signed. label Aug 13, 2021
@jonathanmetzman
Copy link
Collaborator Author

TODO:

  1. Add back python3.7 installation from source. No point in making our life harder with a python upgrade as well.
  2. Pin base for Chromium images so we can do this upgrade incrementally.

@jonathanmetzman
initial
bc3bb82
@jonathanmetzman
fix
e3d130d
@jonathanmetzman
Remove 16-specific code
cc9a5b6
@jonathanmetzman
undo bad changes
c7c5980
@jonathanmetzman
Pin ML image to xenial
3b46329 
ML image setup is very xenial specific.
Unclear if Focal is supported by tensorflow docs yet (though bionic is).
@jonathanmetzman
update node. node 11 not available on focal
7bf07ac
jonathanmetzman
jonathanmetzman commented Aug 19, 2021
View reviewed changes
docker/ml-with-gpu/Dockerfile
@@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
FROM gcr.io/clusterfuzz-images/base
FROM gcr.io/clusterfuzz-images/base@sha256:1110514de5bb678562b75e5cf65130923bd22bb9371dcbc9e99483fd277ac135
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning this image for now. Upgrading this will be a very large effort (and for unknown benefit :\

@jonathanmetzman
Copy link
Collaborator Author

/gcbrun

@jonathanmetzman jonathanmetzman requested review from oliverchang and inferno-chromium and removed request for oliverchang August 19, 2021 23:48
@jonathanmetzman
Copy link
Collaborator Author

Related: google/oss-fuzz#6180

oliverchang
oliverchang approved these changes Aug 20, 2021
View reviewed changes
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I'll test this a bit locally first before merging and deploying on a small number of real bots.

oliverchang
oliverchang reviewed Aug 20, 2021
View reviewed changes
docker/base/Dockerfile Outdated Show resolved Hide resolved
@jonathanmetzman jonathanmetzman marked this pull request as ready for review August 20, 2021 00:51
@jonathanmetzman
Copy link
Collaborator Author

/gcbrun

@jonathanmetzman jonathanmetzman enabled auto-merge (squash) August 20, 2021 17:07
@jonathanmetzman jonathanmetzman merged commit 29e7163 into master Aug 20, 2021
@jonathanmetzman jonathanmetzman deleted the update-image branch August 20, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang oliverchang approved these changes

@inferno-chromium inferno-chromium Awaiting requested review from inferno-chromium

Assignees
No one assigned
Labels
cla: yes CLA signed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanmetzman @oliverchang