Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ubuntu version #6180

Closed
jonathanmetzman opened this issue Aug 6, 2021 · 3 comments
Closed

Upgrade Ubuntu version #6180

jonathanmetzman opened this issue Aug 6, 2021 · 3 comments
Milestone
clusterfuzzlite l...

Comments

@jonathanmetzman
Copy link
Contributor

jonathanmetzman commented Aug 6, 2021 •
edited
Loading

We need to do this eventually. I don't want to do it after ClusterFuzzLite launches because I don't want to break people so soon after releasing a project. Delaying this only makes the problem worse.

So far, I've tested a few major projects/configurations. I tested each sanitizer, each engine, each architecture, and each language. It seems like only the swift projects are breaking.
We expect some MSAN users to break also.
@jonathanmetzman
Copy link
Contributor Author

We'll also need to coordinate this with ClusterFuzz and FuzzBench.
ClusterFuzz has seperate docker images that OSS-Fuzz images must run on.
FuzzBench depends on OSS-Fuzz images.

@jonathanmetzman jonathanmetzman added this to the cifuzz external milestone Aug 6, 2021
@jonathanmetzman jonathanmetzman mentioned this issue Aug 6, 2021
Merged
jonathanmetzman added a commit to google/fuzzbench that referenced this issue Aug 9, 2021
@jonathanmetzman
Upgrade Ubuntu version to focal (20.04)
0c4570a 
Related: google/oss-fuzz#6180
@oliverchang
Copy link
Collaborator

+1. We can make migration a little easier if the downstream consumers (ClusterFuzz + FuzzBench) if we upload a 16.04 tag and have those depend on that first.

@jonathanmetzman jonathanmetzman mentioned this issue Aug 10, 2021
Closed
@tstruk tstruk mentioned this issue Aug 10, 2021
Merged
@oliverchang oliverchang mentioned this issue Aug 11, 2021
Closed
jonathanmetzman added a commit to google/fuzzbench that referenced this issue Aug 17, 2021
@jonathanmetzman
Pin images to specific base-builder and base-clang build.
fb35de9 
This is so that we don't have to upgrade FuzzBench images when
OSS-Fuzz images upgrade.

This is related to google/oss-fuzz#6180
@jonathanmetzman jonathanmetzman mentioned this issue Aug 17, 2021
Merged
jonathanmetzman added a commit to google/clusterfuzz that referenced this issue Aug 17, 2021
@jonathanmetzman
Pin Fuchsia and Chromium images to specific base images.
63052cc 
This is so that we don't have to these images when
we upgrade the OSS-Fuzz images.

This is related to google/oss-fuzz#6180
@jonathanmetzman jonathanmetzman mentioned this issue Aug 17, 2021
Merged
jonathanmetzman added a commit that referenced this issue Aug 17, 2021
@jonathanmetzman
[Ubuntu Upgrade] Disable MSAN builds on projects that will break.
c7d9d62 
Related: #6180
@jonathanmetzman jonathanmetzman mentioned this issue Aug 17, 2021
Closed
jonathanmetzman added a commit that referenced this issue Aug 17, 2021
@jonathanmetzman
[Ubuntu Upgrade] Upgrade msan parts to reflect new reality.
5146152 
All dependencies must be built with MSAN by the project.
OSS-Fuzz will not be providing any instrumented libraries.

Related: #6180
@jonathanmetzman jonathanmetzman mentioned this issue Aug 17, 2021
Merged
jonathanmetzman added a commit to google/clusterfuzz that referenced this issue Aug 19, 2021
@jonathanmetzman
Pin Fuchsia and Chromium images to specific base images. (#2415)
7250424 
This is so that we don't have to these images when
we upgrade the OSS-Fuzz images.

This is related to google/oss-fuzz#6180
This was referenced Aug 19, 2021
Closed
Merged
jonathanmetzman added a commit that referenced this issue Aug 20, 2021
@jonathanmetzman
[infra] Add a script for building all base-images with "-testing"
a4f0906 
suffix and pushing them to gcr.io/oss-fuzz-base.

This is useful for testing changes to images.
I used it to test changes I made for #6180.
This does not support msan as that image is being removed.

Also lint.
@jonathanmetzman jonathanmetzman mentioned this issue Aug 20, 2021
Merged
jonathanmetzman added a commit that referenced this issue Aug 20, 2021
@jonathanmetzman
[cifuzz] Handle upgrade to Ubuntu 20.04
f71e53d 
1. Don't do any special handling for MSAN anymore. It isn't needed.
2. Don't do any special handling for msan-libs-builder it doesn't
exist anymore.
3. Don't copy python anymore. python3 comes with base-runner.

Related: #6180
@jonathanmetzman jonathanmetzman mentioned this issue Aug 20, 2021
Merged
@jonathanmetzman jonathanmetzman mentioned this issue Aug 20, 2021
Merged
jonathanmetzman added a commit that referenced this issue Aug 20, 2021
@jonathanmetzman
Install python in projects that depend on it.
790a38b 
When we upgrade to 20.04, python wont be in base-builder and
these projects will fail unless they install it.
Until then, this change should be a noop.

Related: #6180
@jonathanmetzman jonathanmetzman mentioned this issue Aug 20, 2021
Merged
jonathanmetzman added a commit that referenced this issue Aug 20, 2021
@jonathanmetzman
[ubuntu upgrade] Dont install ninja
9c988b5 
ninja-build is the intended package name. ninja-build isn't actually
needed for this project anyway.
ninja is not the build tool and isn't available in Ubuntu 20.04.
Removing this to prevent breakage.
Related: #6180
jonathanmetzman added a commit that referenced this issue Aug 20, 2021
@jonathanmetzman
[ffmpeg] Prepare for upgrade to Ubuntu 20.04
05fb5a4 
install libdrm-dev.

Don't rely on cd accepting multiple arguments.
This behavior doesn't work in Ubuntu 20.04.
Related: #6180
@jonathanmetzman jonathanmetzman mentioned this issue Aug 20, 2021
Merged
jonathanmetzman added a commit that referenced this issue Aug 26, 2021
@jonathanmetzman
[Ubuntu upgrade] Fix projects so they don't break with upgrade. (#6304)
5549d80 
Fix projects so they don't break with upgrade.
These fixes are likely not backwards compatible and will fail on
Ubuntu 16.04.
Related: #6180
jonathanmetzman added a commit that referenced this issue Aug 26, 2021
@jonathanmetzman
Reland [Ubuntu upgrade] Fix projects so they don't break with upgrade
6f6fac5 
This reverts commit 878c324.

Related: #6180
@jonathanmetzman jonathanmetzman mentioned this issue Aug 26, 2021
Merged
jonathanmetzman added a commit that referenced this issue Aug 26, 2021
@jonathanmetzman
[Ubuntu upgrade][infra] Remove deploy for msan-build
dbe5808 
Related: #6180
@jonathanmetzman jonathanmetzman mentioned this issue Aug 26, 2021
Merged
jonathanmetzman added a commit that referenced this issue Aug 26, 2021
@jonathanmetzman
[Ubuntu upgrade][infra] Remove deploy for msan-build (#6314)
6fc72b3 
Related: #6180
jonathanmetzman added a commit that referenced this issue Aug 26, 2021
@jonathanmetzman
[Ubuntu upgrade] Upgrade images to Ubuntu 20.04 (#6305)
7ca0037 
Related: #6180.
jonathanmetzman added a commit that referenced this issue Aug 26, 2021
@jonathanmetzman
Reland [Ubuntu upgrade] Fix projects so they don't break with upgrade (…
03d1837 
…#6313)

This reverts commit 878c324.

Related: #6180
jonathanmetzman added a commit that referenced this issue Aug 26, 2021
@jonathanmetzman
[cifuzz] Handle upgrade to Ubuntu 20.04 (#6249)
b30e4f4 
Handle upgrade to Ubuntu 20.04

1. Don't do any special handling for MSAN anymore. It isn't needed.
2. Don't do any special handling for msan-libs-builder it doesn't
exist anymore.

Related: #6180
jonathanmetzman added a commit to google/fuzzbench that referenced this issue Aug 26, 2021
@jonathanmetzman
Pin images to specific base-builder and base-clang build. (#1225)
e05ffec 
This is so that we don't have to upgrade FuzzBench images when
OSS-Fuzz images upgrade.

This is related to google/oss-fuzz#6180
This was referenced Aug 26, 2021
Merged
Open
jonathanmetzman added a commit that referenced this issue Aug 27, 2021
@jonathanmetzman
[base-images] Pin base-builder-swift instead of base-builder-new
291a152 
to fix breakage.

This is intended to fix the same breakage as
#6327. But this fix does
not prevent us from creating new language builder images that do
not use xenial.

Related: #6180
@pietroborrello pietroborrello mentioned this issue Aug 30, 2021
Merged
This was referenced Aug 30, 2021
Closed
Closed
@pietroborrello pietroborrello mentioned this issue Aug 31, 2021
Closed
jonathanmetzman added a commit that referenced this issue Aug 31, 2021
@jonathanmetzman
Remove base-sanitizer-libs-builder
0319f51 
Related: #6180
@jonathanmetzman jonathanmetzman mentioned this issue Aug 31, 2021
Merged
jonathanmetzman added a commit that referenced this issue Aug 31, 2021
@jonathanmetzman
[NFC][Ubuntu upgrade] Remove base-sanitizer-libs-builder (#6364)
2888a96 
Functionality was already removed. This is basically dead code right now.
Related: #6180
@oliverchang
Copy link
Collaborator

This is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
clusterfuzzlite launch
Development

No branches or pull requests
2 participants
@oliverchang @jonathanmetzman