Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions Secrets do not support ListOptions #1882

Closed
nadenf opened this issue Jun 5, 2021 · 0 comments · Fixed by #1883
Closed

Actions Secrets do not support ListOptions #1882

nadenf opened this issue Jun 5, 2021 · 0 comments · Fixed by #1883
Assignees
@gmlewis
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Comments

@nadenf
Copy link

nadenf commented Jun 5, 2021

Referring to this issue:
integrations/terraform-provider-github#793

In the Terraform AWS Provider we make a call to:

client.Actions.ListSelectedReposForOrgSecret

But based on the API it will only return 30 results per page and we need to paginate over the rest to get the full list of repositories.

ListSelectedReposForOrgSecret however does not support passing in ListOptions to do this.
@gmlewis gmlewis self-assigned this Jun 5, 2021
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jun 5, 2021
@gmlewis gmlewis mentioned this issue Jun 5, 2021
Merged
gmlewis added a commit that referenced this issue Jun 7, 2021
@gmlewis
Add ListOptions to ListSelectedReposForOrgSecret (#1883)
edaee9a 
Fixes: #1882.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmlewis gmlewis

Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ListOptions to ListSelectedReposForOrgSecret gmlewis/go-github
2 participants
@nadenf @gmlewis