github_actions_organization_secret problem to manage more than 30 selected_repository_ids

[kantipov]

Terraform Version

Terraform v0.15.3 on linux_amd64

• provider registry.terraform.io/integrations/github v4.9.4

Affected Resource(s)

• github_actions_organization_secret

Terraform Configuration Files

resource "github_actions_organization_secret" "organization_secret" {
  for_each                = var.ci_secrets
  secret_name             = each.key
  plaintext_value         = each.value
  visibility              = "selected"
  selected_repository_ids = local.repo_ci_id
}

Expected Behavior

The second run of the terraform apply command should return "Infrastructure is up to date".

Actual Behavior

Important moment - our local.repo_ci_id contains 38 elements (I've checked with 30 elements - the issue doesn't appear).
There are no errors and everything is created correctly on the github after initial terraform apply.
But if I change nothing and run terraform apply again - terraform says:

  # github_actions_organization_secret.organization_secret["GH_PACKAGES_READ"] will be updated in-place
  ~ resource "github_actions_organization_secret" "organization_secret" {
        id                      = "GH_PACKAGES_READ"
      ~ selected_repository_ids = [
          + 152713862,
          + 153690132,
          + 172287326,
          + 183595907,
          + 187405088,
          + 227825871,
          + 230234231,
          + 247816281,
            # (30 unchanged elements hidden)
        ]
        # (5 unchanged attributes hidden)
    }

And, if I answer "yes" - I'll get this error:

Error: Provider produced inconsistent result after apply

When applying changes to github_actions_organization_secret.organization_secret["GH_PACKAGES_READ"], provider
"provider[\"registry.terraform.io/integrations/github\"]" produced an unexpected new value: Root resource was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own issue tracker.

After that everything is still correct on the github, but in the terraform.state there are only 30 id in github_actions_organization_secret.selected_repository_ids.
And, if I run terraform apply again - it will "create" the secret without error. The circle is closed.

Steps to Reproduce

1. Create at least 31 github repository
2. Create github_actions_organization_secret with visibility = "selected" and selected_repository_ids from 1.
3. Run terraform apply
4. Run terraform apply

[nadenf]

Looked into this. Blocked on go-github fixing #1882 and then it can be fixed in this provider.

[gmlewis]

I apologize for the omission. Code reviews and approval welcome at: google/go-github#1883 in order to move this along.