Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu upgrade] Fix projects so they don't break with upgrade. #6304

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

jonathanmetzman
Copy link
Contributor

Fix projects so they don't break with upgrade.
These fixes are likely not backwards compatible and will fail on
Ubuntu 16.04.
Related: #6180

Fix projects so they don't break with upgrade.
These fixes are likely not backwards compatible and will fail on
Ubuntu 16.04.
Related: #6180
@jonathanmetzman
Copy link
Contributor Author

jonathanmetzman commented Aug 26, 2021

This PR depends on #6305 landing first and should land right after it lands.

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jonathanmetzman jonathanmetzman enabled auto-merge (squash) August 26, 2021 05:14
@jonathanmetzman jonathanmetzman merged commit 5549d80 into master Aug 26, 2021
@jonathanmetzman jonathanmetzman deleted the ubuntu-upgrade-fixes branch August 26, 2021 05:14
@oliverchang
Copy link
Collaborator

#6305 hasn't landed yet. Do we need to revert this for now?

@jonathanmetzman
Copy link
Contributor Author

Don't know why i jumped the gun on this. Thanks for catching my mistake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants