[Ubuntu upgrade] Copy files from base-builder/ to base-builder-new/ #6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two of these changes that are important for the Ubuntu upgrade are the changes to "compile" and write_labels.py"
|
Related: #6180 |
inferno-chromium
approved these changes
Aug 26, 2021
base-builder-new is for splitting up base-image by language, so part of a separate migration before we can remove it. |
jonathanmetzman
added a commit
that referenced
this pull request
Aug 27, 2021
In #6322 compile was synced with the version in base-builder. However, base-builder's compile assumes that rust and go are installed. This change makes it possible to run compile without those installed.
jonathanmetzman
added a commit
that referenced
this pull request
Aug 27, 2021
In #6322 compile was synced with the version in base-builder. However, base-builder's compile assumes that rust and go are installed. This change makes it possible to run compile without those installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of these changes that are important for the Ubuntu upgrade are
the changes to "compile" and write_labels.py"