-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example use with a monorepo #286
Comments
@tjdavis3 two approaches you might consider, if you want to release the modules independently, I have an example of monorepo tags in action here -- The only thing we might need to dig into, is whether it works as expected with go. An exciting new approach for managing monorepos, is what @joeldodge79 has been working on here, manifest based releasers. I'd be tempted to try out the latter. |
I'm running into same issue. @bcoe your suggestions are about when to trigger release-please-action, but the issues we are facing is, after release-please is called, it find change, but does not create pr, here is the error message I'm getting:
|
We have a monorepo using release-please-action here -> https:/Financial-Times/origami It is working really well for us, thank you to all the people who worked on release-please and the action! <3 |
Thanks for sharing the example, @JakeChampion! Please, I can see a difference in the The README: if: ${{ steps.release.outputs.release_created }} Your example: if: ${{ steps.release.outputs.releases_created }} Notice the "release_s_" (multiple). Is there a particular difference between using |
I don't know what the difference is, hopefully a release-please maintainer could answer that for you. What I do know, is our release process is working perfectly for us since we moved to using release-please and the release-please-action |
I can suspect that |
If anybody's struggling with proper release in a monorepo, note that you must use:
Notice "releases" not Using |
@JakeChampion Thanks for sharing your example. I've a monorepo where:
Is your workflow similar? @bcoe is this something release-please can do on its own (in conjunction with |
is the "elbow grease" manual or automated? in our sdk-codegen repo we end up with lots of tags and releases but release-please does it for us. then we use
|
It's bunch of extra bash commands to format tags as per lerna's liking and also create pre-release versions of packages. I checked origmai repo but I couldn't find any workflow that runs on release PR close, so I was wondering how you manage creating release PRs (at this point create pre-release versions of package), and closing release PRs (at this point create final version of package). |
Part of the complexity comes from the fact that |
In case it's relevant, we're on an old version of release-please-action (hopefully updating to latest in the next few months)
using
I don't have it all in my brain right now but we got it setup so that our
We don't publish pre-release versions. However, I believe |
Ah, it makes sense now. In both cases (merging feature PR to main and release PR to main) will trigger release-please so you don't need a special
In that case, I'll take a look again. I was thinking of ditching lerna publish altogether and use
I didn't see any support for pre-release versions to package registry (I saw draft and prerelease for github releases) but now that I understand how Thanks for your help! |
I'm not exactly sure how |
I see. Looks like I can use the pre-release version to publish to package registry. I'll give it a try, thanks! |
So prerelease only works for premajor versions. For anything >1.0.0, it creates regular releases. The action doesn't provide
Looks like I need to hack the summary and parse out |
I am attempting to test with a simple monorepo with two projects. A vue.js frontend and a golang backend. I've attempted to setup an action for each along with the path. When I do not use the
multirepo-tags: true
option I get errors. However, when setting it to true there is never a PR created.On a commit with a subject of:
fix(frontend): Update
the following output is received:Is there an example of exactly how to use release-please with a monorepo and what exactly
monorepo-tags
does?The text was updated successfully, but these errors were encountered: