-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow prerelease releases on Github #1181
Conversation
Thank you for the PR @kalosisz 👏 might take a few days to review due to NY but excited for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and this is looking great!
If I'm reading this right, it's not affecting the commits we consider since the last release. Are you intending to use this on a separate release branch? If not, when it comes time to release a stable version, it won't grab all the commits since the last stable version - it will grab since last release of any type on the release branch. (FWIW, we are probably going to be maintaining a preview
branch in the near future which runs in parallel to the main
branch and would probably use this --prerelease
option).
@chingor13 you are right. it would always consider the last release if it's not releaseing from a different branch. I think it would be nice if one could specify to only consider stable releases (only storing those in the |
allow prereleases on Github for versions with prerelease (eg beta) for better marking non-production state of a release
they aren't used downstream. Add spy testing the correct octokit call args.
remove passing prerelease for manifest options in cli and removing not needed tets
hey @chingor13. I was thinking on having to generate the release notes on a prerelease from a stable. I reckon the library could have another flag for that for if one has a preview branch and only want to create release notes between prereleases, it What do you think? |
How would prerelease versioning work? |
Versionings are managed in Check out release-please/src/strategies/base.ts Lines 102 to 103 in a7977bc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be ok with having it always create the release as prerelease
on GitHub. A repo maintainer may want to turn on that flag for pre-1.0.0 versions.
@chingor13 So far I was looking only at the prerelease part, but based on your last comment, I added releasing pre-major as prereleaes in 6f3b7e5 I see my new commits didn't remove your approval? Is this intentional? |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1180 🦕