Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation for redis in Go #894

Merged
merged 21 commits into from
May 31, 2024
Merged

Conversation

grcevski
Copy link
Contributor

This is the Go instrumentation version for #891.

Relates to #879

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

Attention: Patch coverage is 90.83333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 77.92%. Comparing base (05ff13a) to head (8e51bbc).

Files Patch % Lines
pkg/internal/ebpf/goredis/goredis.go 90.27% 6 Missing and 1 partial ⚠️
pkg/internal/ebpf/common/redis_detect_transform.go 91.11% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
+ Coverage   77.77%   77.92%   +0.15%     
==========================================
  Files         123      124       +1     
  Lines        8737     8857     +120     
==========================================
+ Hits         6795     6902     +107     
- Misses       1494     1503       +9     
- Partials      448      452       +4     
Flag Coverage Δ
integration-test 54.43% <25.00%> (-0.57%) ⬇️
k8s-integration-test 60.06% <25.00%> (-0.51%) ⬇️
oats-test 35.92% <90.83%> (+0.80%) ⬆️
unittests 43.09% <2.50%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great!

@grcevski grcevski merged commit 84a37be into grafana:main May 31, 2024
6 checks passed
@grcevski grcevski deleted the redis_go branch May 31, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants