Update block hex to be 8 bytes in length #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nana-EC <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 66.39% 66.46% +0.06%
==========================================
Files 4 4
Lines 491 492 +1
Branches 66 66
==========================================
+ Hits 326 327 +1
Misses 148 148
Partials 17 17
Continue to review full report at Codecov.
|
possible-panther
approved these changes
Jun 3, 2022
Nana-EC
added a commit
that referenced
this pull request
Jun 3, 2022
Our current implementation returns `0x0` for nonce on a block response. However the expectation is an 8byte - Update `eth.ts` to use `0x0000000000000000` for nonce - Update tests Signed-off-by: Nana-EC <[email protected]>
Nana-EC
added a commit
that referenced
this pull request
Jun 3, 2022
Update block hex to be 8 bytes in length (#156) Our current implementation returns `0x0` for nonce on a block response. However the expectation is an 8byte - Update `eth.ts` to use `0x0000000000000000` for nonce - Update tests Signed-off-by: Nana-EC <[email protected]>
possible-panther
pushed a commit
that referenced
this pull request
Jun 8, 2022
Our current implementation returns `0x0` for nonce on a block response. However the expectation is an 8byte - Update `eth.ts` to use `0x0000000000000000` for nonce - Update tests Signed-off-by: Nana-EC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nana-EC [email protected]
Description:
Our current implementation returns
0x0for nonce on a block response.However the expectation is an 8byte
eth.tsto use0x0000000000000000for nonceRelated issue(s):
Fixes #149
Notes for reviewer:
Checklist