Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block hex to be 8 bytes in length (release 0.1) #157

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Jun 3, 2022

Our current implementation returns 0x0 for nonce on a block response.
However the expectation is an 8byte

  • Update eth.ts to use 0x0000000000000000 for nonce
  • Update tests

Signed-off-by: Nana-EC [email protected]

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Our current implementation returns `0x0` for nonce on a block response.
However the expectation is an 8byte

- Update `eth.ts` to use `0x0000000000000000` for nonce
- Update tests

Signed-off-by: Nana-EC <[email protected]>
@Nana-EC Nana-EC changed the title Update block hex to be 8 bytes in length (#156) Update block hex to be 8 bytes in length (release 0.1) Jun 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC Nana-EC self-assigned this Jun 3, 2022
@Nana-EC Nana-EC added bug Something isn't working P1 labels Jun 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #157 (2be004e) into release/0.1 (26649c1) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 2be004e differs from pull request most recent head e2d7ecc. Consider uploading reports for the commit e2d7ecc to get more accurate results

@@               Coverage Diff               @@
##           release/0.1     #157      +/-   ##
===============================================
+ Coverage        66.39%   66.46%   +0.06%     
===============================================
  Files                4        4              
  Lines              491      492       +1     
  Branches            66       66              
===============================================
+ Hits               326      327       +1     
  Misses             148      148              
  Partials            17       17              
Impacted Files Coverage Δ
packages/relay/src/lib/eth.ts 51.42% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26649c1...e2d7ecc. Read the comment docs.

@Nana-EC Nana-EC added this to the 0.1.0 milestone Jun 3, 2022
@Nana-EC Nana-EC merged commit f8d6053 into release/0.1 Jun 3, 2022
@Nana-EC Nana-EC deleted the 149-0-1-8bye-block-hash branch June 3, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants