Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Support AWS_S3_US_EAST_1_REGIONAL_ENDPOINT environment variable with AWS SDK for Go v2 #33874

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Respect a valid value for the AWS_S3_US_EAST_1_REGIONAL_ENDPOINT environment variable when configuring the S3 API client.

Relations

Closes #33872.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. labels Oct 10, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 10, 2023
@ewbankkit ewbankkit changed the title S3: Support AWS_S3_US_EAST_1_REGIONAL_ENDPOINT environment variable with AWS SDK for Go v2 [WIP] S3: Support AWS_S3_US_EAST_1_REGIONAL_ENDPOINT environment variable with AWS SDK for Go v2 Oct 10, 2023
@ewbankkit ewbankkit changed the title [WIP] S3: Support AWS_S3_US_EAST_1_REGIONAL_ENDPOINT environment variable with AWS SDK for Go v2 S3: Support AWS_S3_US_EAST_1_REGIONAL_ENDPOINT environment variable with AWS SDK for Go v2 Oct 10, 2023
@ewbankkit ewbankkit merged commit 4697d0a into main Oct 11, 2023
33 checks passed
@ewbankkit ewbankkit deleted the b-AWS_S3_US_EAST_1_REGIONAL_ENDPOINT-aws-sdk-go-v2 branch October 11, 2023 12:04
@github-actions github-actions bot added this to the v5.21.0 milestone Oct 11, 2023
github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
@github-actions
Copy link

This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3: Support AWS_S3_US_EAST_1_REGIONAL_ENDPOINT environment variable with AWS SDK for Go v2
1 participant