[resource/identitystore_group] displayName change does not force replacement

[jylitalo]

Description

Change in AWS IdentityStore Group DisplayName should be handled as modifies instead of 'forces replament'

Relations

Closes #39415

References

Described in #39415

Output from Acceptance Testing

% gmake testacc TESTS=TestAccIdentityStoreGroup_displayNameChange PKG=identitystore
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 20 -run='TestAccIdentityStoreGroup_displayNameChange'  -timeout 360m
=== RUN   TestAccIdentityStoreGroup_displayNameChange
=== PAUSE TestAccIdentityStoreGroup_displayNameChange
=== CONT  TestAccIdentityStoreGroup_displayNameChange
--- PASS: TestAccIdentityStoreGroup_displayNameChange (23.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/identitystore      28.244s...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @jylitalo 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIdentityStoreGroup' PKG=identitystore ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/identitystore/... -v -count 1 -parallel 2  -run=TestAccIdentityStoreGroup -timeout 360m
=== RUN   TestAccIdentityStoreGroupDataSource_filterDisplayName
=== PAUSE TestAccIdentityStoreGroupDataSource_filterDisplayName
=== RUN   TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
=== PAUSE TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
=== RUN   TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID
=== PAUSE TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID
=== RUN   TestAccIdentityStoreGroupMembership_basic
=== PAUSE TestAccIdentityStoreGroupMembership_basic
=== RUN   TestAccIdentityStoreGroupMembership_disappears
=== PAUSE TestAccIdentityStoreGroupMembership_disappears
=== RUN   TestAccIdentityStoreGroupMembership_GroupId
=== PAUSE TestAccIdentityStoreGroupMembership_GroupId
=== RUN   TestAccIdentityStoreGroupMembership_MemberId
=== PAUSE TestAccIdentityStoreGroupMembership_MemberId
=== RUN   TestAccIdentityStoreGroup_basic
=== PAUSE TestAccIdentityStoreGroup_basic
=== RUN   TestAccIdentityStoreGroup_disappears
=== PAUSE TestAccIdentityStoreGroup_disappears
=== RUN   TestAccIdentityStoreGroup_descriptionChange
=== PAUSE TestAccIdentityStoreGroup_descriptionChange
=== RUN   TestAccIdentityStoreGroup_displayNameChange
=== PAUSE TestAccIdentityStoreGroup_displayNameChange
=== RUN   TestAccIdentityStoreGroupsDataSource_basic
=== PAUSE TestAccIdentityStoreGroupsDataSource_basic
=== CONT  TestAccIdentityStoreGroupDataSource_filterDisplayName
=== CONT  TestAccIdentityStoreGroupMembership_MemberId
--- PASS: TestAccIdentityStoreGroupDataSource_filterDisplayName (16.47s)
=== CONT  TestAccIdentityStoreGroup_descriptionChange
--- PASS: TestAccIdentityStoreGroupMembership_MemberId (36.38s)
=== CONT  TestAccIdentityStoreGroupsDataSource_basic
--- PASS: TestAccIdentityStoreGroup_descriptionChange (26.47s)
=== CONT  TestAccIdentityStoreGroup_displayNameChange
--- PASS: TestAccIdentityStoreGroupsDataSource_basic (19.03s)
=== CONT  TestAccIdentityStoreGroup_disappears
--- PASS: TestAccIdentityStoreGroup_displayNameChange (30.04s)
=== CONT  TestAccIdentityStoreGroup_basic
--- PASS: TestAccIdentityStoreGroup_disappears (17.62s)
=== CONT  TestAccIdentityStoreGroupMembership_basic
--- PASS: TestAccIdentityStoreGroupMembership_basic (17.56s)
=== CONT  TestAccIdentityStoreGroupMembership_GroupId
--- PASS: TestAccIdentityStoreGroup_basic (18.30s)
=== CONT  TestAccIdentityStoreGroupMembership_disappears
--- PASS: TestAccIdentityStoreGroupMembership_disappears (14.86s)
=== CONT  TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID
--- PASS: TestAccIdentityStoreGroupMembership_GroupId (25.07s)
=== CONT  TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
--- PASS: TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID (13.69s)
--- PASS: TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName (12.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	133.908s

% make testacc TESTARGS='-run=TestAccIdentityStoreUser' PKG=identitystore ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/identitystore/... -v -count 1 -parallel 2  -run=TestAccIdentityStoreUser -timeout 360m
=== RUN   TestAccIdentityStoreUserDataSource_basic
=== PAUSE TestAccIdentityStoreUserDataSource_basic
=== RUN   TestAccIdentityStoreUserDataSource_filterUserName
=== PAUSE TestAccIdentityStoreUserDataSource_filterUserName
=== RUN   TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== PAUSE TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== RUN   TestAccIdentityStoreUserDataSource_email
=== PAUSE TestAccIdentityStoreUserDataSource_email
=== RUN   TestAccIdentityStoreUserDataSource_userID
=== PAUSE TestAccIdentityStoreUserDataSource_userID
=== RUN   TestAccIdentityStoreUser_basic
=== PAUSE TestAccIdentityStoreUser_basic
=== RUN   TestAccIdentityStoreUser_disappears
=== PAUSE TestAccIdentityStoreUser_disappears
=== RUN   TestAccIdentityStoreUser_Addresses
=== PAUSE TestAccIdentityStoreUser_Addresses
=== RUN   TestAccIdentityStoreUser_Emails
=== PAUSE TestAccIdentityStoreUser_Emails
=== RUN   TestAccIdentityStoreUser_Locale
=== PAUSE TestAccIdentityStoreUser_Locale
=== RUN   TestAccIdentityStoreUser_NameFamilyName
=== PAUSE TestAccIdentityStoreUser_NameFamilyName
=== RUN   TestAccIdentityStoreUser_NameFormatted
=== PAUSE TestAccIdentityStoreUser_NameFormatted
=== RUN   TestAccIdentityStoreUser_NameGivenName
=== PAUSE TestAccIdentityStoreUser_NameGivenName
=== RUN   TestAccIdentityStoreUser_NameHonorificPrefix
=== PAUSE TestAccIdentityStoreUser_NameHonorificPrefix
=== RUN   TestAccIdentityStoreUser_NameHonorificSuffix
=== PAUSE TestAccIdentityStoreUser_NameHonorificSuffix
=== RUN   TestAccIdentityStoreUser_NameMiddleName
=== PAUSE TestAccIdentityStoreUser_NameMiddleName
=== RUN   TestAccIdentityStoreUser_NickName
=== PAUSE TestAccIdentityStoreUser_NickName
=== RUN   TestAccIdentityStoreUser_PhoneNumbers
=== PAUSE TestAccIdentityStoreUser_PhoneNumbers
=== RUN   TestAccIdentityStoreUser_PreferredLanguage
=== PAUSE TestAccIdentityStoreUser_PreferredLanguage
=== RUN   TestAccIdentityStoreUser_ProfileURL
=== PAUSE TestAccIdentityStoreUser_ProfileURL
=== RUN   TestAccIdentityStoreUser_Timezone
=== PAUSE TestAccIdentityStoreUser_Timezone
=== RUN   TestAccIdentityStoreUser_Title
=== PAUSE TestAccIdentityStoreUser_Title
=== RUN   TestAccIdentityStoreUser_UserType
=== PAUSE TestAccIdentityStoreUser_UserType
=== CONT  TestAccIdentityStoreUserDataSource_basic
=== CONT  TestAccIdentityStoreUser_NameGivenName
--- PASS: TestAccIdentityStoreUserDataSource_basic (13.04s)
=== CONT  TestAccIdentityStoreUser_PreferredLanguage
--- PASS: TestAccIdentityStoreUser_NameGivenName (24.93s)
=== CONT  TestAccIdentityStoreUser_UserType
--- PASS: TestAccIdentityStoreUser_PreferredLanguage (36.11s)
=== CONT  TestAccIdentityStoreUser_Title
--- PASS: TestAccIdentityStoreUser_UserType (36.06s)
=== CONT  TestAccIdentityStoreUser_Timezone
--- PASS: TestAccIdentityStoreUser_Title (35.86s)
=== CONT  TestAccIdentityStoreUser_ProfileURL
=== CONT  TestAccIdentityStoreUser_NameMiddleName
--- PASS: TestAccIdentityStoreUser_Timezone (35.87s)
--- PASS: TestAccIdentityStoreUser_ProfileURL (35.78s)
=== CONT  TestAccIdentityStoreUser_PhoneNumbers
--- PASS: TestAccIdentityStoreUser_NameMiddleName (35.79s)
=== CONT  TestAccIdentityStoreUser_NickName
--- PASS: TestAccIdentityStoreUser_NickName (36.30s)
=== CONT  TestAccIdentityStoreUser_disappears
--- PASS: TestAccIdentityStoreUser_PhoneNumbers (50.68s)
=== CONT  TestAccIdentityStoreUser_NameFormatted
--- PASS: TestAccIdentityStoreUser_disappears (12.10s)
=== CONT  TestAccIdentityStoreUser_NameFamilyName
--- PASS: TestAccIdentityStoreUser_NameFamilyName (23.39s)
=== CONT  TestAccIdentityStoreUser_Locale
--- PASS: TestAccIdentityStoreUser_NameFormatted (35.31s)
=== CONT  TestAccIdentityStoreUser_Addresses
--- PASS: TestAccIdentityStoreUser_Locale (35.52s)
=== CONT  TestAccIdentityStoreUser_NameHonorificSuffix
--- PASS: TestAccIdentityStoreUser_Addresses (50.47s)
=== CONT  TestAccIdentityStoreUserDataSource_email
--- PASS: TestAccIdentityStoreUserDataSource_email (12.08s)
=== CONT  TestAccIdentityStoreUser_basic
--- PASS: TestAccIdentityStoreUser_NameHonorificSuffix (35.21s)
=== CONT  TestAccIdentityStoreUserDataSource_userID
--- PASS: TestAccIdentityStoreUser_basic (14.58s)
=== CONT  TestAccIdentityStoreUser_NameHonorificPrefix
--- PASS: TestAccIdentityStoreUserDataSource_userID (11.68s)
=== CONT  TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
--- PASS: TestAccIdentityStoreUserDataSource_uniqueAttributeUserName (12.09s)
=== CONT  TestAccIdentityStoreUser_Emails
--- PASS: TestAccIdentityStoreUser_NameHonorificPrefix (23.23s)
=== CONT  TestAccIdentityStoreUserDataSource_filterUserName
--- PASS: TestAccIdentityStoreUserDataSource_filterUserName (11.64s)
--- PASS: TestAccIdentityStoreUser_Emails (50.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	354.712s

[ewbankkit]

@jylitalo Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!