Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS App Mesh service discovery using AWS Cloud Map #8997

Closed
ewbankkit opened this issue Jun 14, 2019 · 9 comments · Fixed by #9271
Closed

AWS App Mesh service discovery using AWS Cloud Map #8997

ewbankkit opened this issue Jun 14, 2019 · 9 comments · Fixed by #9271
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Jun 14, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS App Mesh now supports AWS Cloud Map as a service discovery method.

New or Affected Resource(s)

References

AWS announcement.

Requires:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 14, 2019
@atali
Copy link

atali commented Jun 25, 2019

It means you will support the awsCloudMap keywords ?

{
   "meshName":"simpleapp",
   "spec":{
      "backends":[
         {
            "virtualService":{
               "virtualServiceName":"serviceB.simpleapp.local"
            }
         }
      ],
      "listeners":[
         {
            "portMapping":{
               "port":8080,
               "protocol":"http"
            }
         }
      ],
      "serviceDiscovery": {
            "awsCloudMap": {
                  "namespaceName": "simpleapp.local",
                  "serviceName": "serviceA",
                  "attributes": [
                   {
                        "key": "ENVIRONMENT",
                        "value": "Testing"
                   }
             ]
      }
}
   }
}

@ewbankkit
Copy link
Contributor Author

@atali Yes, haven't had time to think about the exact syntax but most likely will use the syntax from the API (snake case instead of camel case).

@atali
Copy link

atali commented Jun 25, 2019

@ewbankkit perfect, thanks a lot for your answer.
Actually, I am trying to use ECS Fargate + AppMesh with terraform. I would like to query through CloudMap API but I am blocked without these feature.

Do you have any workaround until the feature will be done ?
Do you have an ETA ?

Thanks for your excellent work !

@ewbankkit
Copy link
Contributor Author

I suggest we get #8111 merged first.

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Jul 8, 2019

Testing the Cloud Map service name will require #7016, fixed via #7341.
Actually the Cloud Map service name doesn't have to exist when configuring the Virtual Node, although merging #7341 would be useful 😄.

@bflad bflad added the service/appmesh Issues and PRs that pertain to the appmesh service. label Jul 9, 2019
@bflad bflad added this to the v2.19.0 milestone Jul 9, 2019
@bflad
Copy link
Contributor

bflad commented Jul 9, 2019

Support for AWS Cloud Map has been merged for the aws_appmesh_virtual_node resource and will release with version 2.19.0 of the Terraform AWS Provider, likely later this week. 👍 Thanks, @ewbankkit!

@atali
Copy link

atali commented Jul 9, 2019

great job ! thanks @ewbankkit!

@bflad
Copy link
Contributor

bflad commented Jul 11, 2019

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants