Issue #7016 support http namespaces in service discovery

[saravanan30erd]

Fixes #7016

Changes proposed in this pull request:

• Change 1
  support http namespaces in service discovery service.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSServiceDiscoveryService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSServiceDiscoveryService_ -timeout 120m
=== RUN   TestAccAWSServiceDiscoveryService_private
=== PAUSE TestAccAWSServiceDiscoveryService_private
=== RUN   TestAccAWSServiceDiscoveryService_public
=== PAUSE TestAccAWSServiceDiscoveryService_public
=== RUN   TestAccAWSServiceDiscoveryService_http
=== PAUSE TestAccAWSServiceDiscoveryService_http
=== RUN   TestAccAWSServiceDiscoveryService_import
=== PAUSE TestAccAWSServiceDiscoveryService_import
=== CONT  TestAccAWSServiceDiscoveryService_private
=== CONT  TestAccAWSServiceDiscoveryService_import
=== CONT  TestAccAWSServiceDiscoveryService_http
=== CONT  TestAccAWSServiceDiscoveryService_public
--- PASS: TestAccAWSServiceDiscoveryService_http (122.07s)
--- PASS: TestAccAWSServiceDiscoveryService_public (165.72s)
--- PASS: TestAccAWSServiceDiscoveryService_import (201.34s)
--- PASS: TestAccAWSServiceDiscoveryService_private (264.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws
...

[saravanan30erd]

@bflad Could you please look on it?

[namliz]

@bflad It'd be useful if this was merged or to get an eta, please and thank you

[gojihotsauce]

This is a blocker for me right now. I'd love an ETA as well.

[ewbankkit]

After rebasing onto b6065fc to fix

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSServiceDiscoveryService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSServiceDiscoveryService_ -timeout 120m
# github.com/terraform-providers/terraform-provider-aws/aws
aws/resource_aws_cloudwatch_event_permission.go:278:2: Printf format %s has arg policy.Statements of wrong type []github.com/terraform-providers/terraform-provider-aws/aws.CloudWatchEventPermissionPolicyStatement
aws/resource_aws_cloudwatch_event_permission.go:288:17: Sprintf format %s has arg policy.Statements of wrong type []github.com/terraform-providers/terraform-provider-aws/aws.CloudWatchEventPermissionPolicyStatement
FAIL	github.com/terraform-providers/terraform-provider-aws/aws [build failed]
make: *** [testacc] Error 2

acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSServiceDiscoveryService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSServiceDiscoveryService_ -timeout 120m
=== RUN   TestAccAWSServiceDiscoveryService_private
=== PAUSE TestAccAWSServiceDiscoveryService_private
=== RUN   TestAccAWSServiceDiscoveryService_public
=== PAUSE TestAccAWSServiceDiscoveryService_public
=== RUN   TestAccAWSServiceDiscoveryService_http
=== PAUSE TestAccAWSServiceDiscoveryService_http
=== RUN   TestAccAWSServiceDiscoveryService_import
=== PAUSE TestAccAWSServiceDiscoveryService_import
=== CONT  TestAccAWSServiceDiscoveryService_private
=== CONT  TestAccAWSServiceDiscoveryService_http
=== CONT  TestAccAWSServiceDiscoveryService_public
=== CONT  TestAccAWSServiceDiscoveryService_import
--- PASS: TestAccAWSServiceDiscoveryService_http (90.22s)
--- PASS: TestAccAWSServiceDiscoveryService_import (106.07s)
--- PASS: TestAccAWSServiceDiscoveryService_public (112.08s)
--- PASS: TestAccAWSServiceDiscoveryService_private (134.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	134.588s

[bflad]

Thanks so much for this, @saravanan30erd. 🚀 My apologies for the delayed review.

--- PASS: TestAccAWSServiceDiscoveryService_http (93.33s)
--- PASS: TestAccAWSServiceDiscoveryService_import (95.58s)
--- PASS: TestAccAWSServiceDiscoveryService_private (100.10s)
--- PASS: TestAccAWSServiceDiscoveryService_public (107.99s)

[bflad]

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!