Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_s3_object (et al.): Remove kms:DescribeKey on default S3 KMS key #39782

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

aws_s3_object (et al.): Remove kms:DescribeKey on default S3 KMS key #39782

wants to merge 11 commits into from
+165 −69

Conversation

ewbankkit
Copy link
Contributor

Description

Removes the KMS call to describe the default S3 KMS key -- least privilege.
The addition of Computed to the kms_key_id attribute in #15234 removed the need for this functionality.

Relations

Closes #3450.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3Object_' PKG=s3 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 4  -run=TestAccS3Object_ -timeout 360m
2024/10/17 14:40:29 Initializing Terraform AWS Provider...
=== RUN   TestAccS3Object_tags
=== PAUSE TestAccS3Object_tags
=== RUN   TestAccS3Object_tags_null
=== PAUSE TestAccS3Object_tags_null
=== RUN   TestAccS3Object_tags_EmptyMap
=== PAUSE TestAccS3Object_tags_EmptyMap
=== RUN   TestAccS3Object_tags_AddOnUpdate
=== PAUSE TestAccS3Object_tags_AddOnUpdate
=== RUN   TestAccS3Object_tags_EmptyTag_OnCreate
=== PAUSE TestAccS3Object_tags_EmptyTag_OnCreate
=== RUN   TestAccS3Object_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccS3Object_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccS3Object_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccS3Object_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccS3Object_tags_DefaultTags_providerOnly
=== PAUSE TestAccS3Object_tags_DefaultTags_providerOnly
=== RUN   TestAccS3Object_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccS3Object_tags_DefaultTags_nonOverlapping
=== RUN   TestAccS3Object_tags_DefaultTags_overlapping
=== PAUSE TestAccS3Object_tags_DefaultTags_overlapping
=== RUN   TestAccS3Object_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccS3Object_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccS3Object_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccS3Object_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccS3Object_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccS3Object_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccS3Object_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccS3Object_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccS3Object_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccS3Object_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccS3Object_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccS3Object_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccS3Object_tags_ComputedTag_OnCreate
=== PAUSE TestAccS3Object_tags_ComputedTag_OnCreate
=== RUN   TestAccS3Object_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccS3Object_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccS3Object_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccS3Object_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccS3Object_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccS3Object_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccS3Object_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccS3Object_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccS3Object_basic
=== PAUSE TestAccS3Object_basic
=== RUN   TestAccS3Object_disappears
=== PAUSE TestAccS3Object_disappears
=== RUN   TestAccS3Object_Disappears_bucket
=== PAUSE TestAccS3Object_Disappears_bucket
=== RUN   TestAccS3Object_upgradeFromV4
=== PAUSE TestAccS3Object_upgradeFromV4
=== RUN   TestAccS3Object_source
=== PAUSE TestAccS3Object_source
=== RUN   TestAccS3Object_content
=== PAUSE TestAccS3Object_content
=== RUN   TestAccS3Object_etagEncryption
=== PAUSE TestAccS3Object_etagEncryption
=== RUN   TestAccS3Object_contentBase64
=== PAUSE TestAccS3Object_contentBase64
=== RUN   TestAccS3Object_sourceHashTrigger
=== PAUSE TestAccS3Object_sourceHashTrigger
=== RUN   TestAccS3Object_withContentCharacteristics
=== PAUSE TestAccS3Object_withContentCharacteristics
=== RUN   TestAccS3Object_nonVersioned
=== PAUSE TestAccS3Object_nonVersioned
=== RUN   TestAccS3Object_updates
=== PAUSE TestAccS3Object_updates
=== RUN   TestAccS3Object_updateSameFile
=== PAUSE TestAccS3Object_updateSameFile
=== RUN   TestAccS3Object_updatesWithVersioning
=== PAUSE TestAccS3Object_updatesWithVersioning
=== RUN   TestAccS3Object_updatesWithVersioningViaAccessPoint
=== PAUSE TestAccS3Object_updatesWithVersioningViaAccessPoint
=== RUN   TestAccS3Object_kms
=== PAUSE TestAccS3Object_kms
=== RUN   TestAccS3Object_sse
=== PAUSE TestAccS3Object_sse
=== RUN   TestAccS3Object_acl
=== PAUSE TestAccS3Object_acl
=== RUN   TestAccS3Object_metadata
=== PAUSE TestAccS3Object_metadata
=== RUN   TestAccS3Object_storageClass
=== PAUSE TestAccS3Object_storageClass
=== RUN   TestAccS3Object_tagsLeadingSingleSlash
=== PAUSE TestAccS3Object_tagsLeadingSingleSlash
=== RUN   TestAccS3Object_tagsLeadingMultipleSlashes
=== PAUSE TestAccS3Object_tagsLeadingMultipleSlashes
=== RUN   TestAccS3Object_tagsMultipleSlashes
=== PAUSE TestAccS3Object_tagsMultipleSlashes
=== RUN   TestAccS3Object_tagsViaAccessPointARN
=== PAUSE TestAccS3Object_tagsViaAccessPointARN
=== RUN   TestAccS3Object_tagsViaAccessPointAlias
=== PAUSE TestAccS3Object_tagsViaAccessPointAlias
=== RUN   TestAccS3Object_tagsViaMultiRegionAccessPoint
=== PAUSE TestAccS3Object_tagsViaMultiRegionAccessPoint
=== RUN   TestAccS3Object_tagsViaObjectLambdaAccessPointARN
    object_test.go:1218: Accessing Objects via Lambda Access Points is not yet supported
--- SKIP: TestAccS3Object_tagsViaObjectLambdaAccessPointARN (0.00s)
=== RUN   TestAccS3Object_objectLockLegalHoldStartWithNone
=== PAUSE TestAccS3Object_objectLockLegalHoldStartWithNone
=== RUN   TestAccS3Object_objectLockLegalHoldStartWithOn
=== PAUSE TestAccS3Object_objectLockLegalHoldStartWithOn
=== RUN   TestAccS3Object_objectLockRetentionStartWithNone
=== PAUSE TestAccS3Object_objectLockRetentionStartWithNone
=== RUN   TestAccS3Object_objectLockRetentionStartWithSet
=== PAUSE TestAccS3Object_objectLockRetentionStartWithSet
=== RUN   TestAccS3Object_objectBucketKeyEnabled
=== PAUSE TestAccS3Object_objectBucketKeyEnabled
=== RUN   TestAccS3Object_bucketBucketKeyEnabled
=== PAUSE TestAccS3Object_bucketBucketKeyEnabled
=== RUN   TestAccS3Object_defaultBucketSSE
=== PAUSE TestAccS3Object_defaultBucketSSE
=== RUN   TestAccS3Object_ignoreTags
=== PAUSE TestAccS3Object_ignoreTags
=== RUN   TestAccS3Object_checksumAlgorithm
=== PAUSE TestAccS3Object_checksumAlgorithm
=== RUN   TestAccS3Object_keyWithSlashesMigrated
=== PAUSE TestAccS3Object_keyWithSlashesMigrated
=== RUN   TestAccS3Object_directoryBucket
=== PAUSE TestAccS3Object_directoryBucket
=== RUN   TestAccS3Object_DirectoryBucket_disappears
=== PAUSE TestAccS3Object_DirectoryBucket_disappears
=== RUN   TestAccS3Object_DirectoryBucket_DefaultTags_providerOnly
=== PAUSE TestAccS3Object_DirectoryBucket_DefaultTags_providerOnly
=== RUN   TestAccS3Object_DirectoryBucket_kmsSSE
=== PAUSE TestAccS3Object_DirectoryBucket_kmsSSE
=== RUN   TestAccS3Object_prefix
=== PAUSE TestAccS3Object_prefix
=== RUN   TestAccS3Object_crossRegion
=== PAUSE TestAccS3Object_crossRegion
=== RUN   TestAccS3Object_optInRegion
=== PAUSE TestAccS3Object_optInRegion
=== RUN   TestAccS3Object_defaultKMS
=== PAUSE TestAccS3Object_defaultKMS
=== RUN   TestAccS3Object_defaultKMSUpgrade
=== PAUSE TestAccS3Object_defaultKMSUpgrade
=== RUN   TestAccS3Object_basicUpgrade
=== PAUSE TestAccS3Object_basicUpgrade
=== CONT  TestAccS3Object_tags
=== CONT  TestAccS3Object_updatesWithVersioning
=== CONT  TestAccS3Object_objectBucketKeyEnabled
=== CONT  TestAccS3Object_DirectoryBucket_DefaultTags_providerOnly
--- PASS: TestAccS3Object_DirectoryBucket_DefaultTags_providerOnly (13.59s)
=== CONT  TestAccS3Object_optInRegion
    object_test.go:1875: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccS3Object_optInRegion (0.42s)
=== CONT  TestAccS3Object_basicUpgrade
--- PASS: TestAccS3Object_objectBucketKeyEnabled (14.60s)
=== CONT  TestAccS3Object_defaultKMSUpgrade
--- PASS: TestAccS3Object_updatesWithVersioning (43.58s)
=== CONT  TestAccS3Object_defaultKMS
--- PASS: TestAccS3Object_defaultKMS (19.14s)
=== CONT  TestAccS3Object_prefix
--- PASS: TestAccS3Object_prefix (16.67s)
=== CONT  TestAccS3Object_crossRegion
--- PASS: TestAccS3Object_tags (84.89s)
=== CONT  TestAccS3Object_tagsMultipleSlashes
--- PASS: TestAccS3Object_basicUpgrade (72.43s)
=== CONT  TestAccS3Object_objectLockRetentionStartWithSet
--- PASS: TestAccS3Object_defaultKMSUpgrade (71.84s)
=== CONT  TestAccS3Object_objectLockRetentionStartWithNone
--- PASS: TestAccS3Object_crossRegion (7.87s)
=== CONT  TestAccS3Object_objectLockLegalHoldStartWithOn
--- PASS: TestAccS3Object_objectLockLegalHoldStartWithOn (43.39s)
=== CONT  TestAccS3Object_objectLockLegalHoldStartWithNone
--- PASS: TestAccS3Object_objectLockRetentionStartWithNone (59.30s)
=== CONT  TestAccS3Object_tagsViaMultiRegionAccessPoint
--- PASS: TestAccS3Object_tagsMultipleSlashes (72.68s)
=== CONT  TestAccS3Object_tagsViaAccessPointAlias
--- PASS: TestAccS3Object_objectLockRetentionStartWithSet (72.88s)
=== CONT  TestAccS3Object_tagsViaAccessPointARN
--- PASS: TestAccS3Object_objectLockLegalHoldStartWithNone (43.99s)
=== CONT  TestAccS3Object_DirectoryBucket_kmsSSE
--- PASS: TestAccS3Object_tagsViaAccessPointAlias (33.48s)
=== CONT  TestAccS3Object_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccS3Object_tagsViaAccessPointARN (33.75s)
=== CONT  TestAccS3Object_updateSameFile
--- PASS: TestAccS3Object_DirectoryBucket_kmsSSE (18.93s)
=== CONT  TestAccS3Object_updates
--- PASS: TestAccS3Object_updateSameFile (32.21s)
=== CONT  TestAccS3Object_nonVersioned
    object_test.go:465: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccS3Object_nonVersioned (0.00s)
=== CONT  TestAccS3Object_withContentCharacteristics
--- PASS: TestAccS3Object_updates (33.27s)
=== CONT  TestAccS3Object_sourceHashTrigger
--- PASS: TestAccS3Object_tags_ComputedTag_OnUpdate_Add (39.45s)
=== CONT  TestAccS3Object_contentBase64
--- PASS: TestAccS3Object_withContentCharacteristics (13.87s)
=== CONT  TestAccS3Object_etagEncryption
--- PASS: TestAccS3Object_contentBase64 (13.62s)
=== CONT  TestAccS3Object_content
--- PASS: TestAccS3Object_sourceHashTrigger (27.99s)
=== CONT  TestAccS3Object_source
--- PASS: TestAccS3Object_etagEncryption (16.16s)
=== CONT  TestAccS3Object_upgradeFromV4
--- PASS: TestAccS3Object_content (17.68s)
=== CONT  TestAccS3Object_Disappears_bucket
--- PASS: TestAccS3Object_source (18.84s)
=== CONT  TestAccS3Object_disappears
--- PASS: TestAccS3Object_Disappears_bucket (14.02s)
=== CONT  TestAccS3Object_basic
--- PASS: TestAccS3Object_disappears (14.46s)
=== CONT  TestAccS3Object_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccS3Object_upgradeFromV4 (33.85s)
=== CONT  TestAccS3Object_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccS3Object_basic (16.05s)
=== CONT  TestAccS3Object_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccS3Object_tags_ComputedTag_OnUpdate_Replace (39.12s)
=== CONT  TestAccS3Object_tagsLeadingSingleSlash
--- PASS: TestAccS3Object_tags_IgnoreTags_Overlap_DefaultTag (47.70s)
=== CONT  TestAccS3Object_tagsLeadingMultipleSlashes
--- PASS: TestAccS3Object_tags_IgnoreTags_Overlap_ResourceTag (51.89s)
=== CONT  TestAccS3Object_sse
--- PASS: TestAccS3Object_sse (16.57s)
=== CONT  TestAccS3Object_acl
--- PASS: TestAccS3Object_tagsLeadingSingleSlash (60.71s)
=== CONT  TestAccS3Object_metadata
--- PASS: TestAccS3Object_tagsLeadingMultipleSlashes (58.14s)
=== CONT  TestAccS3Object_storageClass
--- PASS: TestAccS3Object_acl (48.65s)
=== CONT  TestAccS3Object_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccS3Object_metadata (38.55s)
=== CONT  TestAccS3Object_tags_DefaultTags_nonOverlapping
--- PASS: TestAccS3Object_tagsViaMultiRegionAccessPoint (302.58s)
=== CONT  TestAccS3Object_tags_DefaultTags_providerOnly
--- PASS: TestAccS3Object_storageClass (58.57s)
=== CONT  TestAccS3Object_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccS3Object_tags_EmptyTag_OnUpdate_Add (53.32s)
=== CONT  TestAccS3Object_tags_AddOnUpdate
--- PASS: TestAccS3Object_tags_EmptyTag_OnUpdate_Replace (35.81s)
=== CONT  TestAccS3Object_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccS3Object_tags_DefaultTags_nonOverlapping (59.70s)
=== CONT  TestAccS3Object_tags_EmptyTag_OnCreate
--- PASS: TestAccS3Object_tags_AddOnUpdate (35.83s)
=== CONT  TestAccS3Object_tags_ComputedTag_OnCreate
--- PASS: TestAccS3Object_tags_DefaultTags_emptyProviderOnlyTag (22.01s)
=== CONT  TestAccS3Object_tags_EmptyMap
--- PASS: TestAccS3Object_tags_ComputedTag_OnCreate (24.90s)
=== CONT  TestAccS3Object_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccS3Object_tags_DefaultTags_providerOnly (79.44s)
=== CONT  TestAccS3Object_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccS3Object_tags_EmptyTag_OnCreate (38.43s)
=== CONT  TestAccS3Object_tags_null
--- PASS: TestAccS3Object_tags_EmptyMap (28.00s)
=== CONT  TestAccS3Object_kms
--- PASS: TestAccS3Object_tags_DefaultTags_nullNonOverlappingResourceTag (22.08s)
=== CONT  TestAccS3Object_updatesWithVersioningViaAccessPoint
--- PASS: TestAccS3Object_tags_DefaultTags_nullOverlappingResourceTag (22.11s)
=== CONT  TestAccS3Object_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccS3Object_tags_null (27.34s)
=== CONT  TestAccS3Object_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccS3Object_kms (16.68s)
=== CONT  TestAccS3Object_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccS3Object_updatesWithVersioningViaAccessPoint (34.58s)
=== CONT  TestAccS3Object_tags_DefaultTags_overlapping
--- PASS: TestAccS3Object_tags_DefaultTags_emptyResourceTag (22.11s)
=== CONT  TestAccS3Object_directoryBucket
--- PASS: TestAccS3Object_tags_DefaultTags_updateToResourceOnly (37.66s)
=== CONT  TestAccS3Object_DirectoryBucket_disappears
--- PASS: TestAccS3Object_tags_DefaultTags_updateToProviderOnly (37.65s)
=== CONT  TestAccS3Object_keyWithSlashesMigrated
--- PASS: TestAccS3Object_directoryBucket (19.80s)
=== CONT  TestAccS3Object_ignoreTags
--- PASS: TestAccS3Object_DirectoryBucket_disappears (16.56s)
=== CONT  TestAccS3Object_checksumAlgorithm
--- PASS: TestAccS3Object_keyWithSlashesMigrated (33.37s)
=== CONT  TestAccS3Object_defaultBucketSSE
--- PASS: TestAccS3Object_ignoreTags (32.15s)
=== CONT  TestAccS3Object_bucketBucketKeyEnabled
--- PASS: TestAccS3Object_checksumAlgorithm (28.01s)
--- PASS: TestAccS3Object_tags_DefaultTags_overlapping (62.38s)
--- PASS: TestAccS3Object_defaultBucketSSE (15.18s)
--- PASS: TestAccS3Object_bucketBucketKeyEnabled (14.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	650.327s
% make testacc TESTARGS='-run=TestAccS3ObjectCopy_' PKG=s3 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 4  -run=TestAccS3ObjectCopy_ -timeout 360m
2024/10/17 10:51:07 Initializing Terraform AWS Provider...
=== RUN   TestAccS3ObjectCopy_tags
=== PAUSE TestAccS3ObjectCopy_tags
=== RUN   TestAccS3ObjectCopy_tags_null
=== PAUSE TestAccS3ObjectCopy_tags_null
=== RUN   TestAccS3ObjectCopy_tags_EmptyMap
=== PAUSE TestAccS3ObjectCopy_tags_EmptyMap
=== RUN   TestAccS3ObjectCopy_tags_AddOnUpdate
=== PAUSE TestAccS3ObjectCopy_tags_AddOnUpdate
=== RUN   TestAccS3ObjectCopy_tags_EmptyTag_OnCreate
=== PAUSE TestAccS3ObjectCopy_tags_EmptyTag_OnCreate
=== RUN   TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccS3ObjectCopy_tags_DefaultTags_providerOnly
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_providerOnly
=== RUN   TestAccS3ObjectCopy_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_nonOverlapping
=== RUN   TestAccS3ObjectCopy_tags_DefaultTags_overlapping
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_overlapping
=== RUN   TestAccS3ObjectCopy_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccS3ObjectCopy_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccS3ObjectCopy_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccS3ObjectCopy_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccS3ObjectCopy_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccS3ObjectCopy_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccS3ObjectCopy_tags_ComputedTag_OnCreate
=== PAUSE TestAccS3ObjectCopy_tags_ComputedTag_OnCreate
=== RUN   TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccS3ObjectCopy_basic
=== PAUSE TestAccS3ObjectCopy_basic
=== RUN   TestAccS3ObjectCopy_disappears
=== PAUSE TestAccS3ObjectCopy_disappears
=== RUN   TestAccS3ObjectCopy_metadata
=== PAUSE TestAccS3ObjectCopy_metadata
=== RUN   TestAccS3ObjectCopy_grant
=== PAUSE TestAccS3ObjectCopy_grant
=== RUN   TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== RUN   TestAccS3ObjectCopy_BucketKeyEnabled_object
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_object
=== RUN   TestAccS3ObjectCopy_sourceWithSlashes
=== PAUSE TestAccS3ObjectCopy_sourceWithSlashes
=== RUN   TestAccS3ObjectCopy_checksumAlgorithm
=== PAUSE TestAccS3ObjectCopy_checksumAlgorithm
=== RUN   TestAccS3ObjectCopy_objectLockLegalHold
=== PAUSE TestAccS3ObjectCopy_objectLockLegalHold
=== RUN   TestAccS3ObjectCopy_targetWithMultipleSlashes
=== PAUSE TestAccS3ObjectCopy_targetWithMultipleSlashes
=== RUN   TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated
=== PAUSE TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated
=== RUN   TestAccS3ObjectCopy_directoryBucket
=== PAUSE TestAccS3ObjectCopy_directoryBucket
=== RUN   TestAccS3ObjectCopy_basicViaAccessPoint
=== PAUSE TestAccS3ObjectCopy_basicViaAccessPoint
=== CONT  TestAccS3ObjectCopy_tags
=== CONT  TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccS3ObjectCopy_BucketKeyEnabled_object
=== CONT  TestAccS3ObjectCopy_targetWithMultipleSlashes
--- PASS: TestAccS3ObjectCopy_targetWithMultipleSlashes (15.94s)
=== CONT  TestAccS3ObjectCopy_tags_DefaultTags_overlapping
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_object (16.27s)
=== CONT  TestAccS3ObjectCopy_tags_ComputedTag_OnCreate
--- PASS: TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Add (31.09s)
=== CONT  TestAccS3ObjectCopy_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccS3ObjectCopy_tags_ComputedTag_OnCreate (17.77s)
=== CONT  TestAccS3ObjectCopy_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_nullNonOverlappingResourceTag (16.37s)
=== CONT  TestAccS3ObjectCopy_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_nullOverlappingResourceTag (16.42s)
=== CONT  TestAccS3ObjectCopy_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccS3ObjectCopy_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccS3ObjectCopy_tags (52.79s)
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_overlapping (44.98s)
=== CONT  TestAccS3ObjectCopy_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_emptyProviderOnlyTag (17.43s)
=== CONT  TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_emptyResourceTag (16.13s)
=== CONT  TestAccS3ObjectCopy_tags_DefaultTags_nonOverlapping
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_updateToResourceOnly (30.13s)
=== CONT  TestAccS3ObjectCopy_tags_DefaultTags_providerOnly
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_updateToProviderOnly (29.46s)
=== CONT  TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Add (39.78s)
=== CONT  TestAccS3ObjectCopy_tags_AddOnUpdate
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_nonOverlapping (44.48s)
=== CONT  TestAccS3ObjectCopy_tags_EmptyTag_OnCreate
--- PASS: TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Replace (27.50s)
=== CONT  TestAccS3ObjectCopy_checksumAlgorithm
--- PASS: TestAccS3ObjectCopy_tags_AddOnUpdate (28.05s)
=== CONT  TestAccS3ObjectCopy_objectLockLegalHold
--- PASS: TestAccS3ObjectCopy_tags_EmptyTag_OnCreate (27.63s)
=== CONT  TestAccS3ObjectCopy_tags_EmptyMap
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_providerOnly (58.66s)
=== CONT  TestAccS3ObjectCopy_sourceWithSlashes
--- PASS: TestAccS3ObjectCopy_checksumAlgorithm (25.35s)
=== CONT  TestAccS3ObjectCopy_disappears
--- PASS: TestAccS3ObjectCopy_disappears (15.43s)
=== CONT  TestAccS3ObjectCopy_BucketKeyEnabled_bucket
--- PASS: TestAccS3ObjectCopy_tags_EmptyMap (20.78s)
=== CONT  TestAccS3ObjectCopy_grant
--- PASS: TestAccS3ObjectCopy_objectLockLegalHold (31.87s)
=== CONT  TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccS3ObjectCopy_sourceWithSlashes (25.05s)
=== CONT  TestAccS3ObjectCopy_basic
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_bucket (15.02s)
=== CONT  TestAccS3ObjectCopy_tags_null
--- PASS: TestAccS3ObjectCopy_grant (15.46s)
=== CONT  TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccS3ObjectCopy_basic (14.92s)
=== CONT  TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccS3ObjectCopy_tags_null (20.72s)
=== CONT  TestAccS3ObjectCopy_directoryBucket
--- PASS: TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_ResourceTag (43.85s)
=== CONT  TestAccS3ObjectCopy_basicViaAccessPoint
--- PASS: TestAccS3ObjectCopy_directoryBucket (16.10s)
=== CONT  TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated
--- PASS: TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Replace (29.65s)
=== CONT  TestAccS3ObjectCopy_metadata
--- PASS: TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_DefaultTag (40.49s)
--- PASS: TestAccS3ObjectCopy_basicViaAccessPoint (26.63s)
--- PASS: TestAccS3ObjectCopy_metadata (16.74s)
--- PASS: TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated (44.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	260.081s
% make testacc TESTARGS='-run=TestAccS3BucketObject_' PKG=s3 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 4  -run=TestAccS3BucketObject_ -timeout 360m
2024/10/17 13:04:59 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketObject_tags
=== PAUSE TestAccS3BucketObject_tags
=== RUN   TestAccS3BucketObject_tags_null
=== PAUSE TestAccS3BucketObject_tags_null
=== RUN   TestAccS3BucketObject_tags_EmptyMap
=== PAUSE TestAccS3BucketObject_tags_EmptyMap
=== RUN   TestAccS3BucketObject_tags_AddOnUpdate
=== PAUSE TestAccS3BucketObject_tags_AddOnUpdate
=== RUN   TestAccS3BucketObject_tags_EmptyTag_OnCreate
=== PAUSE TestAccS3BucketObject_tags_EmptyTag_OnCreate
=== RUN   TestAccS3BucketObject_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccS3BucketObject_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccS3BucketObject_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccS3BucketObject_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccS3BucketObject_tags_DefaultTags_providerOnly
=== PAUSE TestAccS3BucketObject_tags_DefaultTags_providerOnly
=== RUN   TestAccS3BucketObject_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccS3BucketObject_tags_DefaultTags_nonOverlapping
=== RUN   TestAccS3BucketObject_tags_DefaultTags_overlapping
=== PAUSE TestAccS3BucketObject_tags_DefaultTags_overlapping
=== RUN   TestAccS3BucketObject_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccS3BucketObject_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccS3BucketObject_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccS3BucketObject_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccS3BucketObject_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccS3BucketObject_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccS3BucketObject_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccS3BucketObject_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccS3BucketObject_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccS3BucketObject_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccS3BucketObject_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccS3BucketObject_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccS3BucketObject_tags_ComputedTag_OnCreate
=== PAUSE TestAccS3BucketObject_tags_ComputedTag_OnCreate
=== RUN   TestAccS3BucketObject_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccS3BucketObject_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccS3BucketObject_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccS3BucketObject_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccS3BucketObject_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccS3BucketObject_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccS3BucketObject_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccS3BucketObject_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccS3BucketObject_noNameNoKey
=== PAUSE TestAccS3BucketObject_noNameNoKey
=== RUN   TestAccS3BucketObject_basic
=== PAUSE TestAccS3BucketObject_basic
=== RUN   TestAccS3BucketObject_source
=== PAUSE TestAccS3BucketObject_source
=== RUN   TestAccS3BucketObject_content
=== PAUSE TestAccS3BucketObject_content
=== RUN   TestAccS3BucketObject_etagEncryption
=== PAUSE TestAccS3BucketObject_etagEncryption
=== RUN   TestAccS3BucketObject_contentBase64
=== PAUSE TestAccS3BucketObject_contentBase64
=== RUN   TestAccS3BucketObject_sourceHashTrigger
=== PAUSE TestAccS3BucketObject_sourceHashTrigger
=== RUN   TestAccS3BucketObject_withContentCharacteristics
=== PAUSE TestAccS3BucketObject_withContentCharacteristics
=== RUN   TestAccS3BucketObject_nonVersioned
=== PAUSE TestAccS3BucketObject_nonVersioned
=== RUN   TestAccS3BucketObject_updates
=== PAUSE TestAccS3BucketObject_updates
=== RUN   TestAccS3BucketObject_updateSameFile
=== PAUSE TestAccS3BucketObject_updateSameFile
=== RUN   TestAccS3BucketObject_updatesWithVersioning
=== PAUSE TestAccS3BucketObject_updatesWithVersioning
=== RUN   TestAccS3BucketObject_updatesWithVersioningViaAccessPoint
=== PAUSE TestAccS3BucketObject_updatesWithVersioningViaAccessPoint
=== RUN   TestAccS3BucketObject_kms
=== PAUSE TestAccS3BucketObject_kms
=== RUN   TestAccS3BucketObject_sse
=== PAUSE TestAccS3BucketObject_sse
=== RUN   TestAccS3BucketObject_acl
=== PAUSE TestAccS3BucketObject_acl
=== RUN   TestAccS3BucketObject_metadata
=== PAUSE TestAccS3BucketObject_metadata
=== RUN   TestAccS3BucketObject_storageClass
=== PAUSE TestAccS3BucketObject_storageClass
=== RUN   TestAccS3BucketObject_tagsLeadingSingleSlash
=== PAUSE TestAccS3BucketObject_tagsLeadingSingleSlash
=== RUN   TestAccS3BucketObject_tagsLeadingMultipleSlashes
=== PAUSE TestAccS3BucketObject_tagsLeadingMultipleSlashes
=== RUN   TestAccS3BucketObject_tagsMultipleSlashes
=== PAUSE TestAccS3BucketObject_tagsMultipleSlashes
=== RUN   TestAccS3BucketObject_objectLockLegalHoldStartWithNone
=== PAUSE TestAccS3BucketObject_objectLockLegalHoldStartWithNone
=== RUN   TestAccS3BucketObject_objectLockLegalHoldStartWithOn
=== PAUSE TestAccS3BucketObject_objectLockLegalHoldStartWithOn
=== RUN   TestAccS3BucketObject_objectLockRetentionStartWithNone
=== PAUSE TestAccS3BucketObject_objectLockRetentionStartWithNone
=== RUN   TestAccS3BucketObject_objectLockRetentionStartWithSet
=== PAUSE TestAccS3BucketObject_objectLockRetentionStartWithSet
=== RUN   TestAccS3BucketObject_objectBucketKeyEnabled
=== PAUSE TestAccS3BucketObject_objectBucketKeyEnabled
=== RUN   TestAccS3BucketObject_bucketBucketKeyEnabled
=== PAUSE TestAccS3BucketObject_bucketBucketKeyEnabled
=== RUN   TestAccS3BucketObject_defaultBucketSSE
=== PAUSE TestAccS3BucketObject_defaultBucketSSE
=== RUN   TestAccS3BucketObject_ignoreTags
=== PAUSE TestAccS3BucketObject_ignoreTags
=== CONT  TestAccS3BucketObject_tags
=== CONT  TestAccS3BucketObject_etagEncryption
=== CONT  TestAccS3BucketObject_storageClass
=== CONT  TestAccS3BucketObject_objectLockRetentionStartWithNone
--- PASS: TestAccS3BucketObject_etagEncryption (18.12s)
=== CONT  TestAccS3BucketObject_ignoreTags
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (45.54s)
=== CONT  TestAccS3BucketObject_defaultBucketSSE
--- PASS: TestAccS3BucketObject_ignoreTags (32.33s)
=== CONT  TestAccS3BucketObject_bucketBucketKeyEnabled
--- PASS: TestAccS3BucketObject_defaultBucketSSE (15.45s)
=== CONT  TestAccS3BucketObject_objectBucketKeyEnabled
=== CONT  TestAccS3BucketObject_objectLockRetentionStartWithSet
--- PASS: TestAccS3BucketObject_storageClass (61.10s)
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (15.67s)
=== CONT  TestAccS3BucketObject_tagsMultipleSlashes
--- PASS: TestAccS3BucketObject_tags (74.28s)
=== CONT  TestAccS3BucketObject_objectLockLegalHoldStartWithOn
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (14.30s)
=== CONT  TestAccS3BucketObject_objectLockLegalHoldStartWithNone
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (31.10s)
=== CONT  TestAccS3BucketObject_updatesWithVersioning
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (57.99s)
=== CONT  TestAccS3BucketObject_metadata
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (45.02s)
=== CONT  TestAccS3BucketObject_acl
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (58.79s)
=== CONT  TestAccS3BucketObject_sse
--- PASS: TestAccS3BucketObject_updatesWithVersioning (33.86s)
=== CONT  TestAccS3BucketObject_kms
--- PASS: TestAccS3BucketObject_sse (16.72s)
=== CONT  TestAccS3BucketObject_updatesWithVersioningViaAccessPoint
--- PASS: TestAccS3BucketObject_kms (16.71s)
=== CONT  TestAccS3BucketObject_tagsLeadingMultipleSlashes
--- PASS: TestAccS3BucketObject_metadata (37.41s)
=== CONT  TestAccS3BucketObject_sourceHashTrigger
--- PASS: TestAccS3BucketObject_acl (49.59s)
=== CONT  TestAccS3BucketObject_withContentCharacteristics
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (32.58s)
=== CONT  TestAccS3BucketObject_contentBase64
--- PASS: TestAccS3BucketObject_withContentCharacteristics (13.84s)
=== CONT  TestAccS3BucketObject_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccS3BucketObject_sourceHashTrigger (28.29s)
=== CONT  TestAccS3BucketObject_content
--- PASS: TestAccS3BucketObject_contentBase64 (14.61s)
=== CONT  TestAccS3BucketObject_source
--- PASS: TestAccS3BucketObject_content (16.85s)
=== CONT  TestAccS3BucketObject_basic
--- PASS: TestAccS3BucketObject_source (16.38s)
=== CONT  TestAccS3BucketObject_noNameNoKey
--- PASS: TestAccS3BucketObject_tags_DefaultTags_emptyProviderOnlyTag (22.45s)
=== CONT  TestAccS3BucketObject_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccS3BucketObject_noNameNoKey (1.27s)
=== CONT  TestAccS3BucketObject_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (58.63s)
=== CONT  TestAccS3BucketObject_nonVersioned
    bucket_object_test.go:330: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccS3BucketObject_nonVersioned (0.00s)
=== CONT  TestAccS3BucketObject_updateSameFile
--- PASS: TestAccS3BucketObject_basic (16.38s)
=== CONT  TestAccS3BucketObject_updates
--- PASS: TestAccS3BucketObject_updateSameFile (35.08s)
=== CONT  TestAccS3BucketObject_tags_ComputedTag_OnCreate
--- PASS: TestAccS3BucketObject_updates (37.97s)
=== CONT  TestAccS3BucketObject_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccS3BucketObject_tags_IgnoreTags_Overlap_DefaultTag (54.25s)
=== CONT  TestAccS3BucketObject_tags_DefaultTags_providerOnly
--- PASS: TestAccS3BucketObject_tags_IgnoreTags_Overlap_ResourceTag (58.28s)
=== CONT  TestAccS3BucketObject_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccS3BucketObject_tags_ComputedTag_OnCreate (25.87s)
=== CONT  TestAccS3BucketObject_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccS3BucketObject_tags_DefaultTags_emptyResourceTag (22.07s)
=== CONT  TestAccS3BucketObject_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccS3BucketObject_tags_ComputedTag_OnUpdate_Add (39.83s)
=== CONT  TestAccS3BucketObject_tags_DefaultTags_overlapping
--- PASS: TestAccS3BucketObject_tags_DefaultTags_updateToResourceOnly (37.97s)
=== CONT  TestAccS3BucketObject_tags_DefaultTags_nonOverlapping
--- PASS: TestAccS3BucketObject_tags_DefaultTags_updateToProviderOnly (38.15s)
=== CONT  TestAccS3BucketObject_tagsLeadingSingleSlash
--- PASS: TestAccS3BucketObject_tags_DefaultTags_providerOnly (79.48s)
=== CONT  TestAccS3BucketObject_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccS3BucketObject_tags_DefaultTags_overlapping (60.55s)
=== CONT  TestAccS3BucketObject_tags_EmptyTag_OnCreate
--- PASS: TestAccS3BucketObject_tags_DefaultTags_nullNonOverlappingResourceTag (22.17s)
=== CONT  TestAccS3BucketObject_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccS3BucketObject_tags_DefaultTags_nonOverlapping (61.21s)
=== CONT  TestAccS3BucketObject_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (61.00s)
=== CONT  TestAccS3BucketObject_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccS3BucketObject_tags_EmptyTag_OnCreate (38.61s)
=== CONT  TestAccS3BucketObject_tags_EmptyMap
--- PASS: TestAccS3BucketObject_tags_EmptyTag_OnUpdate_Replace (36.54s)
=== CONT  TestAccS3BucketObject_tags_AddOnUpdate
--- PASS: TestAccS3BucketObject_tags_DefaultTags_nullOverlappingResourceTag (23.79s)
=== CONT  TestAccS3BucketObject_tags_null
--- PASS: TestAccS3BucketObject_tags_EmptyMap (28.17s)
=== CONT  TestAccS3BucketObject_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccS3BucketObject_tags_EmptyTag_OnUpdate_Add (52.97s)
--- PASS: TestAccS3BucketObject_tags_AddOnUpdate (35.88s)
--- PASS: TestAccS3BucketObject_tags_null (27.65s)
--- PASS: TestAccS3BucketObject_tags_ComputedTag_OnUpdate_Replace (39.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	468.328s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. service/kms Issues and PRs that pertain to the kms service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 17, 2024
ewbankkit
ewbankkit commented Oct 17, 2024
View reviewed changes
internal/service/s3/object_copy.go
@@ -396,10 +396,6 @@ func resourceObjectCopyRead(ctx context.Context, d *schema.ResourceData, meta in
d.Set("version_id", output.VersionId)
d.Set("website_redirect", output.WebsiteRedirectLocation)

if err := setObjectKMSKeyID(ctx, meta, d, aws.ToString(output.SSEKMSKeyId)); err != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this call above:

d.Set(names.AttrKMSKeyID, output.SSEKMSKeyId)

@ewbankkit ewbankkit marked this pull request as ready for review October 18, 2024 15:55
@ewbankkit ewbankkit requested a review from a team as a code owner October 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/kms Issues and PRs that pertain to the kms service. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kms:DescribeKey on default S3 KMS key should not be required
1 participant
@ewbankkit