Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_s3_object (et al.): Remove kms:DescribeKey on default S3 KMS key #39782

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

aws_s3_object (et al.): Remove kms:DescribeKey on default S3 KMS key #39782

wants to merge 11 commits into from
+165 −69

Commits on Oct 17, 2024

  1. r/aws_s3_object(_copy): Always set 'kms_key_id'.

    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    38153a8 View commit details
    Browse the repository at this point in the history

  2. Fix 'TestAccS3Object_basic' and 'TestAccS3Object_directoryBucket'.

    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0593401 View commit details
    Browse the repository at this point in the history

  3. Revert "Fix 'TestAccS3Object_basic' and 'TestAccS3Object_directoryBuc… 

    …ket'."

This reverts commit 0593401.
    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    93332d5 View commit details
    Browse the repository at this point in the history

  4. r/aws_s3_object: Don't set 'kms_key_id' if it's empty.

    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4d13dff View commit details
    Browse the repository at this point in the history

  5. r/aws_s3_object: DiffSuppressFunc for 'kms_key_id' is not necessary.

    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2005c93 View commit details
    Browse the repository at this point in the history

  6. r/aws_s3_bucket_object: Always set 'kms_key_id' (unless it's empty).

    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f561904 View commit details
    Browse the repository at this point in the history

  7. Add CHANGELOG entries.

    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d18a41d View commit details
    Browse the repository at this point in the history

  8. Remove unused constant.

    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    555056e View commit details
    Browse the repository at this point in the history

  9. Add 'TestAccS3Object_defaultKMS', TestAccS3Object_defaultKMSUpgrade' … 

    …and 'TestAccS3Object_basicUpgrade'.
    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    387bff6 View commit details
    Browse the repository at this point in the history

  10. Correct CHANGELOG entry file name.

    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    494862e View commit details
    Browse the repository at this point in the history

  11. Fix semgrep 'ci.helper-schema-ResourceData-Set-extraneous-nil-check'.

    @ewbankkit
    ewbankkit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6813e75 View commit details
    Browse the repository at this point in the history