Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redigieren #438

Merged
merged 37 commits into from
Dec 21, 2022
Merged

Redigieren #438

merged 37 commits into from
Dec 21, 2022

Conversation

LeaKruehler
Copy link
Collaborator

@LeaKruehler LeaKruehler commented Nov 3, 2022

Korrekturen Rechtschreibung
closes #441

Description

Checklist

  • This pull request is associated to an issue
  • All used resources use a CC BY-SA 4.0 license or less and are marked appropriately, see our contribution guide.
  • All used resources have been added to list_of_all_resources.md
  • New exercises include learning requirements and learning goals.
  • Add someone else as reviewer and wait for approval before merging.

@LeaKruehler
Copy link
Collaborator Author

@PhiSpel Can you help me here? I have no clue, why the CircleCI test are failing.
The details say, that the problem is in line 33 of "erste Schritte in Matlab" but i didn't change anything in that line. Maybe its something about the link?

@joergbrech
Copy link
Member

@PhiSpel
Copy link
Collaborator

PhiSpel commented Nov 3, 2022

@LeaKruehler if you agree, you can merge #440, with which this PR should work.

@LeaKruehler
Copy link
Collaborator Author

Circle CI is still failing. This times its because of the links from the slacklineverband which seem to be unsafe? The links are used as a reference in Aufgabe 4. Do we need new links or shall we just remove them?

@PhiSpel
Copy link
Collaborator

PhiSpel commented Nov 5, 2022

I took the liberty of removing it, it is not necessary for the understanding. A pity that slacklineverband.com does not follow the https protocoll atm, those things are annoying..

PhiSpel
PhiSpel previously approved these changes Nov 7, 2022
@LeaKruehler LeaKruehler merged commit 7ae8143 into master Dec 21, 2022
@LeaKruehler LeaKruehler deleted the LeaKruehler-patch-1 branch December 21, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure Leas changes were kept
3 participants