Whitespace adjustments in index-list.html and index.html #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waldyrious
changed the title
12 tasks
|
@waldyrious Many thanks for this! Could you resolve the conflicts which have been introduced merging mega PR #422? Happy to merge afterwards. Cheers! |
This is unnecessary since in HTML whitespace is collapsed when rendering the page. Note: The replacement command that's removed in this commit was first introduced in commit 6c29e87, when the `helpers/generate-index-list-html.js` file was still called `lib/create-catalog.js`.
- Indent HTML and add line breaks to make the structure more evident (this also helps code editors identify the structure and perform e.g. collapsing of large containers) - Remove unnecessary blank line at the start of the file - Nest script at the end of the body tag rather than outside of it
waldyrious
force-pushed
the
whitespace
branch
from
a2f103f
to
0417a57
Compare
|
Hey @b-g, I've rebased the branch. I checked the old and the new diffs in whitespace-insensitive mode and they seem to be equivalent, so I suppose the changes should be ready to merge :) apologies for the mess — this kind of formatting changes is quite prone to conflict indeed. |
|
@waldyrious Many thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this also helps code editors identify the structure and perform e.g. collapsing of large containers)
index.html's body tag rather than outside of itindex-list.htmlNote: the two-spaces list format was first introduced (without explanation) in commit 6c29e8758e.
(At the time, the
helpers/generate-index-list-html.jsfile was calledlib/create-catalog.js.)