Provided UseCases at ViewModelScope instead of Singleton #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieuwu
approved these changes
Oct 5, 2022
Thanks @hieuwu. I'm glad you liked the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116
Earlier all the
UseCaseswere provided as singleton to each and everyViewModel. Means a single instance of a particularUseCasewas shared across variousViewModels. In this way, even if anyUseCasesis not required by aViewModel, it was still there in application level scope.Now, all the
UseCasesare scoped by@ViewModelScope. Means it will be provided to aViewModelonly when it is required. Also If two (or more)ViewModelsare using same type ofUseCasesthen the instance of use-case for each of them would be different. (Read more in the articles mentioned below, especially the last two).Articles referred: