Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Suggest better ways to configure LSP capabilities #64

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

wookayin
Copy link
Contributor

@wookayin wookayin commented Nov 16, 2023

Using require('cmp_nvim_lsp').default_capabilities() alone will be not
enough. We have to merge with the default LSP capabilities produced by
vim.lsp.protocol.make_client_capabilities().

Closes #42
Closes #44

Using `require('cmp_nvim_lsp').default_capabilities()` alone will be not
enough. We have to merge with the default LSP capabilities producced by
`vim.lsp.protocol.make_client_capabilities()`.

See hrsh7th#42 and hrsh7th#44.
wookayin added a commit to wookayin/nvim-cmp that referenced this pull request Nov 16, 2023
Using `require('cmp_nvim_lsp').default_capabilities()` alone will be not
enough. We have to merge with the default LSP capabilities producced by
`vim.lsp.protocol.make_client_capabilities()`.

See also hrsh7th/cmp-nvim-lsp#64

Closes hrsh7th#1265
@liskin
Copy link

liskin commented Dec 10, 2023

I believe it is enough indeed, as explained here: #44 (comment)

@hrsh7th
Copy link
Owner

hrsh7th commented Dec 10, 2023

LGTM. Thank you.

@hrsh7th hrsh7th merged commit e6a5e75 into hrsh7th:main Dec 10, 2023
hrsh7th added a commit that referenced this pull request Dec 10, 2023
frantisekstanko added a commit to frantisekstanko/dotfiles that referenced this pull request Dec 13, 2023
Using require('cmp_nvim_lsp').default_capabilities() alone will be not
enough. We have to merge with the default LSP capabilities produced by
vim.lsp.protocol.make_client_capabilities().

For more information, see:

hrsh7th/cmp-nvim-lsp#64
frantisekstanko added a commit to frantisekstanko/dotfiles that referenced this pull request Dec 20, 2023
Using require('cmp_nvim_lsp').default_capabilities() alone will be not
enough. We have to merge with the default LSP capabilities produced by
vim.lsp.protocol.make_client_capabilities().

For more information, see:

hrsh7th/cmp-nvim-lsp#64
@wookayin wookayin deleted the docs branch January 15, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about default_capabilities lspconfig default_capabilities not working
3 participants