Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention change to default_capabilities() in breaking changes issue #231 #1265

Open
mikehaertl opened this issue Oct 26, 2022 · 1 comment
Open

Mention change to default_capabilities() in breaking changes issue #231 #1265

mikehaertl opened this issue Oct 26, 2022 · 1 comment

Comments

@mikehaertl
Copy link

I can not comment on #231 but I think the change to default_capabilities() should be mentioned there.
@wookayin
Copy link
Contributor

Agreed. see hrsh7th/cmp-nvim-lsp#38 as well

@mgnsk mgnsk mentioned this issue Jun 14, 2023
Closed
@wookayin wookayin mentioned this issue Nov 16, 2023
Closed
wookayin added a commit to wookayin/nvim-cmp that referenced this issue Nov 16, 2023
@wookayin
docs: suggest a better way to configure LSP capabilities
25143f4 
Using `require('cmp_nvim_lsp').default_capabilities()` alone will be not
enough. We have to merge with the default LSP capabilities producced by
`vim.lsp.protocol.make_client_capabilities()`.

See also hrsh7th/cmp-nvim-lsp#64

Closes hrsh7th#1265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: suggest a better way to configure LSP capabilities wookayin/nvim-cmp
2 participants
@mikehaertl @wookayin