-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending get_locs() #44
Merged
Commits on Feb 28, 2020
-
get_locs(): first filter StatusCode, then make unique *
This is because in some cases records for the same observation well exist with different statuscodes.
Configuration menu - View commit details
-
Copy full SHA for 6438328 - Browse repository at this point
Copy the full SHA 6438328View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24c3631 - Browse repository at this point
Copy the full SHA 24c3631View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08aa34d - Browse repository at this point
Copy the full SHA 08aa34dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3caa064 - Browse repository at this point
Copy the full SHA 3caa064View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84e66d5 - Browse repository at this point
Copy the full SHA 84e66d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16befc4 - Browse repository at this point
Copy the full SHA 16befc4View commit details
Commits on Mar 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4a4c352 - Browse repository at this point
Copy the full SHA 4a4c352View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc6788b - Browse repository at this point
Copy the full SHA dc6788bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cfdac5 - Browse repository at this point
Copy the full SHA 9cfdac5View commit details
Commits on Mar 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c97704d - Browse repository at this point
Copy the full SHA c97704dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2aafae - Browse repository at this point
Copy the full SHA c2aafaeView commit details -
get_locs(): avoid double obswell codes after distinct *
Accomplished by filtering for specific value of fields 'PeilpuntOpenbaarheidTypeCode' and 'PeilpuntOpenbaarheidCode'
Configuration menu - View commit details
-
Copy full SHA for 6690bb6 - Browse repository at this point
Copy the full SHA 6690bb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53f8148 - Browse repository at this point
Copy the full SHA 53f8148View commit details -
Configuration menu - View commit details
-
Copy full SHA for a407b5e - Browse repository at this point
Copy the full SHA a407b5eView commit details
Commits on Mar 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0cab9c0 - Browse repository at this point
Copy the full SHA 0cab9c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e06e9f9 - Browse repository at this point
Copy the full SHA e06e9f9View commit details -
get_locs(): implement obswell_aggr argument *
This provides 4 approaches to aggregate obswell attributes to the location level, as discussed with @w-jan. See function documentation. Note: the use of window functions with dbplyr 1.4.2 generated a warning (here caused by row_number()), as discussed and solved in tidyverse/dbplyr#328 (merged to dbplyr master). As the fixed dbplyr master is currently not released, and watina depended on an (older) dbplyr fork with pivot_wider, a merge between both is now required. It is provided by https:/florisvdh/dbplyr/tree/dbplyr_with_pivot_wider
Configuration menu - View commit details
-
Copy full SHA for 828b2a7 - Browse repository at this point
Copy the full SHA 828b2a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31f3e64 - Browse repository at this point
Copy the full SHA 31f3e64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 428ba7b - Browse repository at this point
Copy the full SHA 428ba7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01852a3 - Browse repository at this point
Copy the full SHA 01852a3View commit details
Commits on Mar 12, 2020
-
- measure filterdepth by the top of the filter - (re)arrange obswells by area_code and loc_code
Configuration menu - View commit details
-
Copy full SHA for ff07964 - Browse repository at this point
Copy the full SHA ff07964View commit details
Commits on Mar 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a014a6a - Browse repository at this point
Copy the full SHA a014a6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce00e85 - Browse repository at this point
Copy the full SHA ce00e85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0854e1d - Browse repository at this point
Copy the full SHA 0854e1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39c9d01 - Browse repository at this point
Copy the full SHA 39c9d01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 396075c - Browse repository at this point
Copy the full SHA 396075cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd5ea1e - Browse repository at this point
Copy the full SHA dd5ea1eView commit details
Commits on Mar 18, 2020
-
get_locs(): improve filterdepth calculation *
filterdepth was originally calculated using the filter bottom, then it was altered (@w-jan) to use the filter top, but eventually we settle using the middle of the filter (well screen).
Configuration menu - View commit details
-
Copy full SHA for c8650d3 - Browse repository at this point
Copy the full SHA c8650d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2138482 - Browse repository at this point
Copy the full SHA 2138482View commit details
Commits on Mar 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0ed468d - Browse repository at this point
Copy the full SHA 0ed468dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.