Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending get_locs() #44

Merged
merged 30 commits into from
Mar 20, 2020
Merged

Extending get_locs() #44

merged 30 commits into from
Mar 20, 2020

Commits on Feb 28, 2020

  1. get_locs(): first filter StatusCode, then make unique *

    This is because in some cases records for the same observation well
    exist with different statuscodes.
    florisvdh committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    6438328 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    24c3631 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08aa34d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3caa064 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    84e66d5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    16befc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. Configuration menu
    Copy the full SHA
    4a4c352 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc6788b View commit details
    Browse the repository at this point in the history
  3. get_locs(): sort rows

    florisvdh committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    9cfdac5 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Configuration menu
    Copy the full SHA
    c97704d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2aafae View commit details
    Browse the repository at this point in the history
  3. get_locs(): avoid double obswell codes after distinct *

    Accomplished by filtering for specific value of fields 'PeilpuntOpenbaarheidTypeCode' and 'PeilpuntOpenbaarheidCode'
    florisvdh committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    6690bb6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    53f8148 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a407b5e View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Configuration menu
    Copy the full SHA
    0cab9c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e06e9f9 View commit details
    Browse the repository at this point in the history
  3. get_locs(): implement obswell_aggr argument *

    This provides 4 approaches to aggregate obswell attributes to the location level, as discussed with @w-jan.
    See function documentation.
    
    Note: the use of window functions with dbplyr 1.4.2 generated a warning (here caused by row_number()), as
    discussed and solved in tidyverse/dbplyr#328 (merged to dbplyr master).
    As the fixed dbplyr master is currently not released, and watina depended on an (older) dbplyr fork with pivot_wider,
    a merge between both is now required.
    It is provided by https:/florisvdh/dbplyr/tree/dbplyr_with_pivot_wider
    florisvdh committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    828b2a7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    31f3e64 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    428ba7b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    01852a3 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. get_locs():

    - measure filterdepth by the top of the filter
    - (re)arrange obswells by area_code and loc_code
    w-jan committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    ff07964 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Configuration menu
    Copy the full SHA
    a014a6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ce00e85 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0854e1d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    39c9d01 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    396075c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dd5ea1e View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. get_locs(): improve filterdepth calculation *

    filterdepth was originally calculated using the filter bottom,
    then it was altered (@w-jan) to use the filter top,
    but eventually we settle using the middle of the filter (well screen).
    florisvdh committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    c8650d3 View commit details
    Browse the repository at this point in the history
  2. get_locs() docu: minor fix

    florisvdh committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    2138482 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Configuration menu
    Copy the full SHA
    0ed468d View commit details
    Browse the repository at this point in the history