Extending get_locs() #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because in some cases records for the same observation well exist with different statuscodes.
Accomplished by filtering for specific value of fields 'PeilpuntOpenbaarheidTypeCode' and 'PeilpuntOpenbaarheidCode'
This provides 4 approaches to aggregate obswell attributes to the location level, as discussed with @w-jan. See function documentation. Note: the use of window functions with dbplyr 1.4.2 generated a warning (here caused by row_number()), as discussed and solved in tidyverse/dbplyr#328 (merged to dbplyr master). As the fixed dbplyr master is currently not released, and watina depended on an (older) dbplyr fork with pivot_wider, a merge between both is now required. It is provided by https:/florisvdh/dbplyr/tree/dbplyr_with_pivot_wider
- measure filterdepth by the top of the filter - (re)arrange obswells by area_code and loc_code
w-jan
approved these changes
Mar 12, 2020
|
Thanks @w-jan for the suggestions. I'll work this a bit further out as discussed previous week. Regarding filter depth however, I've searched around to evaluate what would be the best solution.
|
|
Implemented a few enhancements. Waiting for responses on using |
|
Thanks @w-jan for discussing this with Piet De Becker. We will use |
filterdepth was originally calculated using the filter bottom, then it was altered (@w-jan) to use the filter top, but eventually we settle using the middle of the filter (well screen).
|
Going to merge this one for release candidate You see, not everything shuts down these days ... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@w-jan can you just have a look at the code changes?
This PR (for release candidate 0.3) adds more features to
get_locs():filterdepth):soilsurf_ost(soil surface in Ostend height CRS),tubelength,measuringref_ost(top of tube in Ostend height CRS),obswell_statecode,obswell_state,installdate,stopdate(the latter two are only kept ifobswells = TRUE)filterdepth_guess: try to fill missingfilterdepthvalues withtubelength(as a conservative approach). This is done before applying thefilterdepth_rangeconditionobswell_aggr: to allow for different methods of aggregating observation well attributes per location (3 methods of selecting one well, a fourth method provides the mean values)With thanks to @w-jan for his ideas.