Add Drop Strings Processor #3763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This processor will drop all metrics with string values. This is helpful in cases where the complete set of metrics is unknown or unsure but non numerical values should be avoided. Signed-off-by: Karsten Schnitter <[email protected]>
|
Is this something that can now be addressed with |
|
I agree, that with the right script, this issue can be addressed with the starlark processor plugin. The user has to develop and maintain that script though. Maybe this case can be included in the testdata? I am not so sure, how to test for the type of the metric since starlark is a dynamic language. This is necessary to drop fields based on their type. |
|
I think I'm going to close this in favor of #8438, which is more flexible. Otherwise we might end up with drop_x plugins for all available types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This processor will drop all metrics with string values. This is helpful in
cases where the complete set of metrics is unknown or unsure but non-numerical
values should be avoided, e.g. for compliance reasons.
Required for all PRs: