Starlark example dropbytype #8438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssoroka
reviewed
Nov 19, 2020
|
Left a comment. A further example of a real life use case: sometimes data comes in with dirty types. The field is usually an int, but once in a while some system sticks a string in the type. It would make sense in that case to either drop the field with the unexpected type. You could expand this example to enforcing a schema for a metric. |
|
Sure will try to handle your comments during lunch break... ;-) |
srebhan
force-pushed
the
starlark-example-dropbytype
branch
from
690fda1
to
eface25
Compare
added 6 commits
November 20, 2020 10:15
srebhan
force-pushed
the
starlark-example-dropbytype
branch
from
eface25
to
9685f45
Compare
|
Ok removed the "tag option for removal" to make it more real-life and also added a "drop field by unexpected type example". |
ssoroka
approved these changes
Nov 20, 2020
plugins/processors/starlark/testdata/drop_fields_with_unexpected_type.star
Outdated
Show resolved
Hide resolved
|
LGTM. |
Co-authored-by: Steven Soroka <[email protected]>
ssoroka
reviewed
Nov 27, 2020
plugins/processors/starlark/testdata/drop_fields_with_unexpected_type.star
Show resolved
Hide resolved
ssoroka
pushed a commit
that referenced
this pull request
Dec 1, 2020
(cherry picked from commit 0ce55bb)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Starlark example for dropping fields of metrics by the value type. This is a suitable replacement for PR #3763.