Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request: Support --set-exit-if-changed in melos format #685

Closed
1 task done
spydon opened this issue Mar 29, 2024 · 2 comments
Closed
1 task done

request: Support --set-exit-if-changed in melos format #685

spydon opened this issue Mar 29, 2024 · 2 comments
Labels
feature request good first issue Good for newcomers Type: Accepted

Comments

@spydon
Copy link
Collaborator

spydon commented Mar 29, 2024

Is there an existing feature request for this?

  • I have searched the existing issues.

Command

melos format --set-exit-if-changed

Description

The --set-exit-if-changed flag from dart format would be good to propagate from melos format

Reasoning

When running melos format in CI you usually want to do a check with --set-exit-if-changed.

Additional context and comments

No response
@utamori
Copy link
Contributor

utamori commented Jun 19, 2024

This appears to have already been added

@spydon
Copy link
Collaborator Author

spydon commented Jun 19, 2024

Good catch, was solved by #709

@spydon spydon closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue Good for newcomers Type: Accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spydon @utamori