Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config for the format command #709

Merged

Conversation

jkoenig134
Copy link
Contributor

Description

Added a configuration for the melos format command to manage lineLength and setExitIfChanged using the config.

CLI input will overwrite the config values, but if config states true for setExitIfChanged it cannot be overwritten b/c --set-exit-if-changed is not negatable.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@jkoenig134
Copy link
Contributor Author

@spydon as promised in #708

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit

packages/melos/lib/src/commands/format.dart Outdated Show resolved Hide resolved
@spydon spydon merged commit 5a6ec6f into invertase:main Apr 26, 2024
10 checks passed
@jkoenig134 jkoenig134 deleted the feat/add-config-for-the-format-command branch April 26, 2024 12:24
@jkoenig134
Copy link
Contributor Author

@spydon do you already have plans when this is released?

@spydon
Copy link
Collaborator

spydon commented Apr 26, 2024

@spydon do you already have plans when this is released?

We're trying to land #702 and then do a release. Currently I'm a bit sceptical of those priority groups, I'd rather just have a name for the second priority group and not have the first one at all, and then have the argument name based on that. But we haven't been able to come up with a good name yet, maybe you'd have some suggestion if you had a look? :)

@jkoenig134
Copy link
Contributor Author

@spydon I don't think I know what's going on there, but I can try to get into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants