[staking] Cannot ChangeCandidate when Bucket is Endorsed #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
envestcc
force-pushed
the
pr-changecand
branch
from
42ff5e6
to
26c5f6e
Compare
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4133 +/- ##
==========================================
+ Coverage 75.38% 76.38% +1.00%
==========================================
Files 303 340 +37
Lines 25923 28964 +3041
==========================================
+ Hits 19541 22125 +2584
- Misses 5360 5731 +371
- Partials 1022 1108 +86 ☔ View full report in Codecov by Sentry. |
envestcc
force-pushed
the
pr-changecand
branch
from
1964781
to
b69adc8
Compare
dustinxie
reviewed
Feb 9, 2024
action/protocol/staking/handlers.go
Outdated
| @@ -314,6 +315,9 @@ func (p *Protocol) handleChangeCandidate(ctx context.Context, act *action.Change | |||
| if rErr = validateBucketSelfStake(featureCtx, csm, bucket, false); rErr != nil { | |||
| return log, rErr | |||
| } | |||
| if rErr := validateBucketEndorsement(NewEndorsementStateManager(csm.SM()), bucket, false, blkCtx.BlockHeight); rErr != nil { | |||
There was a problem hiding this comment.
- should this be protected by hard-fork flag?
- if bucket status =
UnEndorsing, it will returnnil. This case is considered OK to change candidate?
There was a problem hiding this comment.
- I think not required, b/c there should be no endorsement before HF, so the validation should pass
- It actually returns error if bucket is UnEndorsing
dustinxie
reviewed
Feb 9, 2024
action/protocol/staking/handlers.go
Outdated
| @@ -357,6 +361,11 @@ func (p *Protocol) handleChangeCandidate(ctx context.Context, act *action.Change | |||
| failureStatus: iotextypes.ReceiptStatus_ErrNotEnoughBalance, | |||
| } | |||
| } | |||
| // clear previous candidate's self stake if the bucket is expired | |||
There was a problem hiding this comment.
- why need this change? change candidate has nothing to do with previous candidate's self-stake bucket
There was a problem hiding this comment.
we should clear self-stake bucket if the bucket is an expired endorse bucket
There was a problem hiding this comment.
then need to check the bucket is an expired endorse bucket? not a regular bucket
CoderZhi
approved these changes
Mar 6, 2024
dustinxie
approved these changes
Mar 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After delegate endorsement introduced, there are two changes when handling ChangeCandidate action:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: