Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output workflow url with test metadata #145

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Conversation

laurentsenta
Copy link
Contributor

@laurentsenta laurentsenta commented Aug 17, 2023

@laurentsenta laurentsenta marked this pull request as draft August 17, 2023 16:02
@laurentsenta laurentsenta changed the title feat: add job url to test metadata feat: output job url with test metadata Aug 17, 2023
@laurentsenta laurentsenta changed the title feat: output job url with test metadata feat: output workflow url with test metadata Aug 21, 2023
@laurentsenta
Copy link
Contributor Author

laurentsenta commented Aug 21, 2023

Note: resorting to workflow url for now, we have the parameter and we can make this more precise later.

It's "easy" to add the job URL:
bd24224

But Github makes it hard for matrix jobs:
ipdxco/job-summary-url-action#12

If this becomes critical to link to the job instead of the workflow, we'll work around this with try / catches and other tweaks. Focusing on getting the whole flow for now.

@laurentsenta laurentsenta marked this pull request as ready for review August 21, 2023 08:03
@laurentsenta laurentsenta merged commit 2a8b181 into main Aug 21, 2023
13 of 16 checks passed
@laurentsenta laurentsenta deleted the feat/with-job-url branch August 21, 2023 15:43
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants