feat: test implementations with reusable jsons #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsenta
force-pushed
the
feat-reusable-jsons
branch
3 times, most recently
from
36ce1c9
to
d157aed
Compare
|
explicit failure on misconfiguration: https:/ipfs/gateway-conformance/actions/runs/5924017480/job/16060746449?pr=146#logs |
36 tasks
I think we should catch it and report success if that's what we expect. Otherwise, it's quite confusing to contributors at this point (myself included) - #147. |
laurentsenta
added a commit
to ipfs/boxo
that referenced
this pull request
Aug 21, 2023
Upload the JSON logs as an artifact that the dashboard generation scripts can retrieve and process. Support for ipfs/gateway-conformance#146
galargh
approved these changes
Aug 21, 2023
@galargh agreed, I think that one error is expected: the dahboard generation could not find the output.json and failed. It does not depend on the gateway test statuses, etc. |
laurentsenta
force-pushed
the
feat-reusable-jsons
branch
from
57853d2
to
2336e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #123
depends on #145
example output: https:/ipfs/gateway-conformance/actions/runs/5924237972/attempts/1#summary-16061404658
related: